Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the

Browse source 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
This commit is contained in:
Joe Atzberger 2008-05-14 11:07:38 -05:00 committed by Joshua Ferraro
parent 8a5672f58b
commit b11c41249b
1 changed files with 25 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
opac/opac-detail.pl
View file

@ -225,20 +225,26 @@ $template->param(
loggedincommenter => $loggedincommenter
);
sub isbn_cleanup ($) {
my $isbn=shift;
if (
$isbn =~ /\b(\d{13})\b/ or
$isbn =~ /\b(\d{10})\b/ or
$isbn =~ /\b(\d{9}X)\b/i
) {
return $1;
}
return undef;
}
# XISBN Stuff
my $xisbn=$dat->{'isbn'};
$xisbn =~ /(\d*[X]*)/;
$template->param(amazonisbn => $1); # FIXME: so it is OK if the ISBN = 'XXXXX' ?
my ($clean, $amazonisbn);
$amazonisbn = $1;
my ($clean,$clean2);
# these might be overkill, but they are better than the regexp above.
if (
$amazonisbn =~ /\b(\d{13})\b/ or
$amazonisbn =~ /\b(\d{10})\b/ or
$amazonisbn =~ /\b(\d{9}X)\b/i
) {
$clean = $1;
$template->param(clean_isbn => $1);
if ($clean = isbn_cleanup($xisbn)){
$template->param(clean_isbn => $clean);
}
if (C4::Context->preference("OPACFRBRizeEditions")==1) {
@ -305,8 +311,12 @@ while (my $this_item = $sth_shelfbrowse_previous->fetchrow_hashref()) {
$sth_get_biblio->execute($this_item->{biblionumber});
while (my $this_biblio = $sth_get_biblio->fetchrow_hashref()) {
$this_item->{'title'} = $this_biblio->{'title'};
if ($clean2 = isbn_cleanup($this_biblio->{'isbn'})) {
$this_item->{'isbn'} = $clean2;
} else {
$this_item->{'isbn'} = $this_biblio->{'isbn'};
}
}
unshift @previous_items, $this_item;
}
my $throwaway = pop @previous_items;
@ -319,8 +329,12 @@ while (my $this_item = $sth_shelfbrowse_next->fetchrow_hashref()) {
$sth_get_biblio->execute($this_item->{biblionumber});
while (my $this_biblio = $sth_get_biblio->fetchrow_hashref()) {
$this_item->{'title'} = $this_biblio->{'title'};
if ($clean2 = isbn_cleanup($this_biblio->{'isbn'})) {
$this_item->{'isbn'} = $clean2;
} else {
$this_item->{'isbn'} = $this_biblio->{'isbn'};
}
}
push @next_items, $this_item;
}