Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28581: Enhance POD for EnqueueLetter

Browse source 
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2021-06-17 14:47:07 +01:00 committed by Kyle M Hall
parent 1c49ccaa8e
commit b14f042e6e
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
C4/Letters.pm
View file

@ -929,11 +929,19 @@ sub _parseletter {
my $success = EnqueueLetter( { letter => $letter, my $success = EnqueueLetter( { letter => $letter,
borrowernumber => '12', message_transport_type => 'email' } ) borrowernumber => '12', message_transport_type => 'email' } )
places a letter in the message_queue database table, which will Places a letter in the message_queue database table, which will
eventually get processed (sent) by the process_message_queue.pl eventually get processed (sent) by the process_message_queue.pl
cronjob when it calls SendQueuedMessages. cronjob when it calls SendQueuedMessages.
return message_id on success Return message_id on success
Parameters
* letter - required; A letter hashref as returned from GetPreparedLetter
* message_transport_type - required; One of the available mtts
* borrowernumber - optional if 'to_address' is passed; The borrowernumber of the patron we enqueuing the notice for
* to_address - optional if 'borrowernumber' is passed; The destination email address for the notice (defaults to patron->notice_email_address)
* from_address - optional; The from address for the notice, defaults to patron->library->from_email_address
* reply_address - optional; The reply address for the notice, defaults to patron->library->reply_to
=cut =cut
@ -1370,6 +1378,8 @@ sub _send_message_by_email {
$branch_returnpath = $library->branchreturnpath; $branch_returnpath = $library->branchreturnpath;
} }
# NOTE: Patron may not be defined above so branch_email may be undefined still
# so we need to fallback to KohaAdminEmailAddress as a last resort.
my $from_address = my $from_address =
$message->{'from_address'} $message->{'from_address'}
|| $branch_email || $branch_email