Bug 15391: Fix HoldsQueue.t tests
Prior to this patch, in HoldsQueue.t:
63 my @item_types = C4::ItemType->all;
64 my $itemtype = grep { $_->{notforloan} == 1 } @item_types
65 or BAIL_OUT("No adequate itemtype");
Then we use the $itemtype variable (which contains the number of item types not for loan):
92 $dbh->do("INSERT INTO biblioitems (biblionumber, marcxml, itemtype)
93 VALUES ($biblionumber, '', '$itemtype')");
There is obviously something wrong here.
The code should be
64 my @not_for_loan = grep { $_->{notforloan} == 1 } @item_types
65 or BAIL_OUT("No adequate itemtype");
66 my $itemtype = $not_for_loan[0]->{itemtype};
But then some tests don't pass:
Actually the problem comes from:
commit bfbc646fdd
Bug 10336: HoldsQueue.t needs to create its own data
-my $itemtype = $dbh->selectrow_array("SELECT min(itemtype) FROM itemtypes WHERE notforloan = 0")
+my @item_types = C4::ItemType->all;
+my $itemtype = grep { $_->{notforloan} == 1 } @item_types
The line should have been:
my $itemtype = grep { $_->{notforloan} == 0 } @item_types
Test plan:
Confirm that the tests still pass after this patch applied.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
All tests pass pre and post patch
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
This commit is contained in:
parent
6f0cdee69b
commit
b340d1f5bd
1 changed files with 2 additions and 1 deletions
|
@ -61,8 +61,9 @@ my @branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3-
|
||||||
my @other_branches = ( $library2->{branchcode}, $library3->{branchcode} );
|
my @other_branches = ( $library2->{branchcode}, $library3->{branchcode} );
|
||||||
my $least_cost_branch_code = pop @other_branches;
|
my $least_cost_branch_code = pop @other_branches;
|
||||||
my @item_types = C4::ItemType->all;
|
my @item_types = C4::ItemType->all;
|
||||||
my $itemtype = grep { $_->{notforloan} == 1 } @item_types
|
my @for_loan = grep { $_->{notforloan} == 0 } @item_types
|
||||||
or BAIL_OUT("No adequate itemtype");
|
or BAIL_OUT("No adequate itemtype");
|
||||||
|
my $itemtype = $for_loan[0]->{itemtype};
|
||||||
|
|
||||||
#Set up the stage
|
#Set up the stage
|
||||||
# Sysprefs and cost matrix
|
# Sysprefs and cost matrix
|
||||||
|
|
Loading…
Reference in a new issue