Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29772: Regression tests

Browse source 
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Tomás Cohen Arazi 2021-12-27 11:37:35 -03:00 committed by Fridolin Somers
parent 770e263b87
commit b3fe6a4ba3
1 changed files with 26 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
t/db_dependent/api/v1/patrons.t
View file

@ -662,9 +662,14 @@ subtest 'delete() tests' => sub {
my $patron = $builder->build_object({ class => 'Koha::Patrons' }); my $patron = $builder->build_object({ class => 'Koha::Patrons' });
t::lib::Mocks::mock_preference('AnonymousPatron', $patron->borrowernumber); t::lib::Mocks::mock_preference('AnonymousPatron', $patron->borrowernumber);
$t->delete_ok("//$userid:$password@/api/v1/patrons/" . $patron->borrowernumber) $t->delete_ok( "//$userid:$password@/api/v1/patrons/" . $patron->borrowernumber )
->status_is(403, 'Anonymous patron cannot be deleted') ->status_is( 409, 'Anonymous patron cannot be deleted' )
->json_is( { error => 'Anonymous patron cannot be deleted' } ); ->json_is(
{
error => 'Anonymous patron cannot be deleted',
error_code => 'is_anonymous_patron'
}
);
t::lib::Mocks::mock_preference('AnonymousPatron', 0); # back to default t::lib::Mocks::mock_preference('AnonymousPatron', 0); # back to default
t::lib::Mocks::mock_preference( 'borrowerRelationship', 'parent' ); t::lib::Mocks::mock_preference( 'borrowerRelationship', 'parent' );
@ -682,21 +687,36 @@ subtest 'delete() tests' => sub {
$t->delete_ok("//$userid:$password@/api/v1/patrons/" . $patron->borrowernumber) $t->delete_ok("//$userid:$password@/api/v1/patrons/" . $patron->borrowernumber)
->status_is(409, 'Patron with checkouts cannot be deleted') ->status_is(409, 'Patron with checkouts cannot be deleted')
->json_is( { error => 'Pending checkouts prevent deletion' } ); ->json_is(
{
error => 'Pending checkouts prevent deletion',
error_code => 'has_checkouts'
}
);
# Make sure it has no pending checkouts # Make sure it has no pending checkouts
$checkout->delete; $checkout->delete;
$t->delete_ok("//$userid:$password@/api/v1/patrons/" . $patron->borrowernumber) $t->delete_ok("//$userid:$password@/api/v1/patrons/" . $patron->borrowernumber)
->status_is(409, 'Patron with debt cannot be deleted') ->status_is(409, 'Patron with debt cannot be deleted')
->json_is( { error => 'Pending debts prevent deletion' } ); ->json_is(
{
error => 'Pending debts prevent deletion',
error_code => 'has_debt'
}
);
# Make sure it has no debt # Make sure it has no debt
$patron->account->pay({ amount => 10, debits => [ $debit ] }); $patron->account->pay({ amount => 10, debits => [ $debit ] });
$t->delete_ok("//$userid:$password@/api/v1/patrons/" . $patron->borrowernumber) $t->delete_ok("//$userid:$password@/api/v1/patrons/" . $patron->borrowernumber)
->status_is(409, 'Patron with guarantees cannot be deleted') ->status_is(409, 'Patron with guarantees cannot be deleted')
->json_is( { error => 'Patron is a guarantor and it prevents deletion' } ); ->json_is(
{
error => 'Patron is a guarantor and it prevents deletion',
error_code => 'has_guarantees'
}
);
# Remove guarantee # Remove guarantee
$patron->guarantee_relationships->delete; $patron->guarantee_relationships->delete;