Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm
Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for BakerTaylor 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Florent Mara <florent.mara@gmail.com> NOTE: Tweaked test plan based on comment #4, Added sign off based on comment #6. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
parent
4fc8b3d6cf
commit
b4479624de
1 changed files with 1 additions and 3 deletions
4
C4/External/BakerTaylor.pm
vendored
4
C4/External/BakerTaylor.pm
vendored
|
@ -29,6 +29,7 @@ use warnings;
|
|||
|
||||
use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $VERSION);
|
||||
use vars qw($user $pass $agent $image_url $link_url);
|
||||
&initialize;
|
||||
|
||||
BEGIN {
|
||||
require Exporter;
|
||||
|
@ -37,9 +38,6 @@ BEGIN {
|
|||
@EXPORT_OK = qw(&availability &content_cafe &image_url &link_url &http_jacket_link);
|
||||
%EXPORT_TAGS = (all=>\@EXPORT_OK);
|
||||
}
|
||||
INIT {
|
||||
&initialize;
|
||||
}
|
||||
|
||||
sub initialize {
|
||||
$user = (@_ ? shift : C4::Context->preference('BakerTaylorUsername') ) || ''; # LL17984
|
||||
|
|
Loading…
Reference in a new issue