Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21725: Use full statement in HAVING rather than constructed column

Browse source 
To test:
1 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t
2 - Apply patch
3 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t
4 - It passes
5 - Have some open/closed and some fully and not full received baskets
6 - View a vendor and confirm baskets are shwn as expected
7 - Check 'Show all baskets' shows all baskets

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Note sure this is the best thing but it fixes the issue

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Nick Clemens 2018-10-30 11:59:26 +00:00
parent 2d3ec5e625
commit b5c456479d
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
C4/Acquisition.pm
View file

@ -713,7 +713,13 @@ sub GetBasketsInfosByBookseller {
unless ( $allbaskets ) {
# Don't show the basket if it's NOT CLOSED or is FULLY RECEIVED
$query.=" HAVING (closedate IS NULL OR (expected_items > 0))"
$query.=" HAVING (closedate IS NULL OR (
SUM(
IF(aqorders.datereceived IS NULL
AND (aqorders.datecancellationprinted IS NULL OR aqorders.datecancellationprinted='0000-00-00')
, aqorders.quantity
, 0)
) > 0))"
}
my $sth = $dbh->prepare($query);