Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27281: (QA follow-up) Restore test for holdingbranch

Browse source 
I inadvertantly removed the test that varified that the items
holdingbranch is unaffected by the call to LostItem. This restores such
a test and adds a few comments to clarify the test transfers.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2021-04-22 09:35:11 +01:00 committed by Jonathan Druart
parent 2a1fb1406a
commit b5db8e9a37
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
t/db_dependent/Circulation.t
View file

@ -3475,16 +3475,18 @@ subtest 'Set waiting flag' => sub {
};
subtest 'Cancel transfers on lost items' => sub {
plan tests => 5;
plan tests => 6;
my $library_to = $builder->build_object( { class => 'Koha::Libraries' } );
my $item = $builder->build_sample_item();
my $holdingbranch = $item->holdingbranch;
# Historic transfer (datearrived is defined)
my $old_transfer = $builder->build_object(
{
class => 'Koha::Item::Transfers',
value => {
itemnumber => $item->itemnumber,
frombranch => $item->holdingbranch,
frombranch => $holdingbranch,
tobranch => $library_to->branchcode,
reason => 'Manual',
datesent => \'NOW()',
@ -3494,12 +3496,13 @@ subtest 'Cancel transfers on lost items' => sub {
}
}
);
# Queued transfer (datesent is undefined)
my $transfer_1 = $builder->build_object(
{
class => 'Koha::Item::Transfers',
value => {
itemnumber => $item->itemnumber,
frombranch => $item->holdingbranch,
frombranch => $holdingbranch,
tobranch => $library_to->branchcode,
reason => 'Manual',
datesent => undef,
@ -3509,12 +3512,13 @@ subtest 'Cancel transfers on lost items' => sub {
}
}
);
# In transit transfer (datesent is defined, datearrived and datecancelled are both undefined)
my $transfer_2 = $builder->build_object(
{
class => 'Koha::Item::Transfers',
value => {
itemnumber => $item->itemnumber,
frombranch => $item->holdingbranch,
frombranch => $holdingbranch,
tobranch => $library_to->branchcode,
reason => 'Manual',
datesent => \'NOW()',
@ -3537,6 +3541,8 @@ subtest 'Cancel transfers on lost items' => sub {
is($transfer_2->cancellation_reason, 'ItemLost', "Cancellation reason was set to 'ItemLost'");
$old_transfer->discard_changes;
is($old_transfer->datecancelled, undef, "Old transfers are unaffected");
$item->discard_changes;
is($item->holdingbranch, $holdingbranch, "Items holding branch remains unchanged");
};
subtest 'CanBookBeIssued | is_overdue' => sub {