Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 17629: Koha::Biblio - Remove ModBiblioframework

Browse source 
There is only one call to C4::Biblio::ModBiblioframework, it's called
just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl
At first glance this call does not seems useful: all the subroutines
called from ModBiblio send the frameworkcode in parameter.

I'd go to remove it, but I'd like to get confirmation by others.

No test plan here, you need a good pair of eyes and deep into the
C4::Biblio code.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2016-11-15 11:10:51 +00:00 committed by Kyle M Hall
parent 46085442e0
commit b664d68ca4
2 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
C4/Biblio.pm
View file

@ -109,7 +109,6 @@ BEGIN {
# To modify something
push @EXPORT, qw(
&ModBiblio
&ModBiblioframework
&ModZebra
&UpdateTotalIssues
&RemoveAllNsb
@ -385,22 +384,6 @@ sub _strip_item_fields {
}
}
=head2 ModBiblioframework
ModBiblioframework($biblionumber,$frameworkcode);
Exported function to modify a biblio framework
=cut
sub ModBiblioframework {
my ( $biblionumber, $frameworkcode ) = @_;
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare( "UPDATE biblio SET frameworkcode=? WHERE biblionumber=?" );
$sth->execute( $frameworkcode, $biblionumber );
return 1;
}
=head2 DelBiblio
my $error = &DelBiblio($biblionumber);

1
cataloguing/addbiblio.pl
View file

@ -837,7 +837,6 @@ if ( $op eq "addbiblio" ) {
BiblioAutoLink( $record, $frameworkcode );
}
if ( $is_a_modif ) {
ModBiblioframework( $biblionumber, $frameworkcode );
ModBiblio( $record, $biblionumber, $frameworkcode );
}
else {