From b6797fdc8708e73eee0cfd7562e55543ed4f5e3b Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 31 Jan 2017 12:41:51 -0300 Subject: [PATCH] Bug 13757: Make Koha::Patron::Modification->store del empty attrs This patch makes Koha::Patron::Modification->store delete the passed attributes that contain empty values. This is the way it currently works, as all opac-editable attributes are presented to the end-user and they are allowed to delete them, and the best way I found to represent the deletion on the modification request is by setting it to the empty string. I chose this way because it is how the staff interface handles it, so it is consistent. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: This time tests pass! - Verify comment #70 on the bug is fixed now - Sign off :-D Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall --- Koha/Patron/Modification.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Koha/Patron/Modification.pm b/Koha/Patron/Modification.pm index e3573ca5ac..718ffe4682 100644 --- a/Koha/Patron/Modification.pm +++ b/Koha/Patron/Modification.pm @@ -135,7 +135,8 @@ sub approve { code => $attr->{code}, attribute => $attr->{value} } - )->store; + )->store + if $attr->{value}; } } catch {