Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34392: Run automated Stylelint fixes on staff CSS

Browse source 
This patch corrects errors raised by the new stylelint configuration in
staff-global.scss. Many of the fixes were made automatically by using
the "--fix" option:

npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
--fix

Some examples of errors found:

    - Expected single space after ":"
    - Expected single space after "("
    - Expected single space before ")"
    - Expected empty line before comment
    - Expected no more than 1 empty line
    - Expected a trailing semicolon

Manual fixes include replacing named colors with hex codes, combining
duplicate selectors, removing empty blocks, etc.

Some warnings remain: "Unexpected !important" requires more than a
quick fix, if we should choose to address them.

To test, apply the patch and rebuild the staff interface CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

The changes affect CSS all around the staff interface, but there should
be no visible results of the patch. Everything should look correct.

The stylelint check should return only warnings about "!important"

npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-09-19 13:37:20 +00:00 committed by Tomas Cohen Arazi
parent 09459e3dd5
commit b680695142
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 553 additions and 523 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1076
koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
View file

File diff suppressed because it is too large Load diff