Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 36876: Correct <span>s around translatable strings in table settings

Browse source 
This patch corrects the way translatable strings are handled in the
table settings template. The switch to Bootstrap WRAPPERs for the
accordion widget included several errors.

To test, apply the patch and go to Administration -> Table settings.

- Confirm that the sections expand and collapse correctly.
- Test the translation process with a language, e.g. fr-FR:
  - In KTD, run: gulp po:update --lang fr-FR
  - Check fr-FR-staff-prog.po for the line referring to
    koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298
  - It should show the whole string "Interlibrary loans"

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Owen Leonard 2024-05-16 12:03:11 +00:00 committed by Katrin Fischer
parent dfd2bc352a
commit b71ee66dd7
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
View file

@ -275,7 +275,7 @@
[% WRAPPER accordion_item %]
[% WRAPPER accordion_heading panel_id="coursereserves" %]
Course <span>reserves</span>
<span>Course reserves</span>
[% END %]
[% WRAPPER accordion_panel panel_id="coursereserves" %]
<h3>Course reserves tables</h3>
@ -285,7 +285,7 @@
[% WRAPPER accordion_item %]
[% WRAPPER accordion_heading panel_id="erm" %]
E-resource <span>management</span>
<span>E-resource management</span>
[% END %]
[% WRAPPER accordion_panel panel_id="erm" %]
<h3>E-resource management tables</h3>
@ -295,7 +295,7 @@
[% WRAPPER accordion_item %]
[% WRAPPER accordion_heading panel_id="illrequests" %]
Interlibrary <span>loans</span>
<span>Interlibrary loans</span>
[% END %]
[% WRAPPER accordion_panel panel_id="illrequests" %]
<h3>Interlibrary loans tables</h3>
@ -315,7 +315,7 @@
[% WRAPPER accordion_item %]
[% WRAPPER accordion_heading panel_id="pos" %]
Point of <span>sale</span>
<span>Point of sale</span>
[% END %]
[% WRAPPER accordion_panel panel_id="pos" %]
<h3>Point of sale tables</h3>