Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29540: Raise flagsrequired in modrequest

Browse source 
Test plan:
Try modrequest with a user having only 'catalogue' perms and the following URLs:
[1] /cgi-bin/koha/reserve/modrequest.pl?reserve_id=XX&CancelBorrowerNumber=XX&CancelItemnumber=XX&biblionumber=XX
    Fill the XXs with correct identifiers for some item level hold.
[2] /cgi-bin/koha/reserve/modrequest_suspendall.pl?suspend=1&suspend_until=2021-12-01&borrowernumber=XX
    Fill the XX with borrowernumber for borrower that has pending holds.
You should see: Error: You do not have permission to access this page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[AMENDED] More consensus for using reserveforothers than circulate_remaining.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Marcel de Rooy 2021-11-22 07:55:47 +00:00 committed by Fridolin Somers
parent 2e5d59d902
commit b8088051e9
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
reserve/modrequest.pl
View file

@ -36,7 +36,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "about.tt",
query => $query,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { reserveforothers => 1 },
}
);

2
reserve/modrequest_suspendall.pl
View file

@ -34,7 +34,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "about.tt",
query => $query,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { reserveforothers => 1 },
}
);