Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31217: OPAC coce.js is not hiding the coce-coverimg div for single-pixel images

Browse source 
This is because opac-detail.tt has coce-coverimg as an ID, but OPAC
coce.js targets coce-coverimg as a class.

opac-detail.tt should be changed to have coce-coverimg as a class.

Test plan:
1. Set your system preferences:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- OpacCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio detail page in the OPAC. Observe a 'Coce image from
Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio detail page in the OPAC. Observe no image is
displayed.

8. View another OPAC biblio detail page that does have a successfully
loading coce image and confirm the source of that image is listed: For
example 'Coce image from Amazon.com' is displayed

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit cbe50d798a)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Alex Buckley 2022-07-26 16:38:29 +12:00 committed by Lucas Gass
parent 1f9c734de4
commit b80ec4fde3
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
View file

@ -102,7 +102,7 @@
[% IF ( Koha.Preference('OPACCoce') && Koha.Preference('CoceProviders') && normalized_isbn ) %] [% IF ( Koha.Preference('OPACCoce') && Koha.Preference('CoceProviders') && normalized_isbn ) %]
[% coce_id = normalized_ean || normalized_isbn %] [% coce_id = normalized_ean || normalized_isbn %]
<div class="cover-image" id="coce-coverimg"> <div class="cover-image coce-coverimg">
[% IF ( coce_id ) %] [% IF ( coce_id ) %]
<a title="Image from Coce" class="[% coce_id | html %]" id="coce-thumbnail-preview"></a> <a title="Image from Coce" class="[% coce_id | html %]" id="coce-thumbnail-preview"></a>
[% END %] [% END %]
@ -1506,7 +1506,7 @@
lightbox_descriptions.push(_("Image from Google Books (<a href='%s'>see the original image</a>)").format($(img).data('link'))); lightbox_descriptions.push(_("Image from Google Books (<a href='%s'>see the original image</a>)").format($(img).data('link')));
} else if( div.attr("id") == "openlibrary-coverimg" ){ } else if( div.attr("id") == "openlibrary-coverimg" ){
lightbox_descriptions.push(_("Image from OpenLibrary (<a href='%s'>see the original image</a>)").format($(img).data('link'))); lightbox_descriptions.push(_("Image from OpenLibrary (<a href='%s'>see the original image</a>)").format($(img).data('link')));
} else if( div.attr("id") == "coce-coverimg" ){ } else if( div.hasClass("coce-coverimg" ) ){
// Identify which service's image is being loaded by Coce // Identify which service's image is being loaded by Coce
var coce_description; var coce_description;
if( $(img).attr("src").indexOf('amazon.com') >= 0 ){ if( $(img).attr("src").indexOf('amazon.com') >= 0 ){