Bug 31625: Reindent tools home and tools sidebar

This patch performs general template cleanup to the tools-home and
tools-menu templates: Make indentation consistent, replace tabs with
spaces, fix invalid HTML.

To test, apply the patch and go to Tools. The page should look correct,
with no visible changes from before the patch.

Go to any tools page which shows the left-hand sidebar, e.g. Patron
lists, Batch item deletion, Inventory, etc. The menu should look
correct.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2022-09-26 14:53:56 +00:00 committed by Tomas Cohen Arazi
parent 69308e76dd
commit b8450e4e5b
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 342 additions and 336 deletions

View file

@ -1,13 +1,13 @@
[% USE Koha %]
<div id="navmenu">
<div id="navmenulist">
<ul>
<div id="navmenulist">
<ul>
<li><a href="/cgi-bin/koha/tools/tools-home.pl">Tools home</a></li>
</ul>
[% IF ( CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_edit_notice_status_triggers || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_moderate_tags || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) ) %]
<h5>Patrons and circulation</h5>
<ul>
</ul>
[% IF ( CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_edit_notice_status_triggers || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_moderate_tags || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) ) %]
<h5>Patrons and circulation</h5>
<ul>
[% IF ( CAN_user_tools_manage_patron_lists ) %]
<li><a href="/cgi-bin/koha/patron_lists/lists.pl">Patron lists</a></li>
[% END %]
@ -44,11 +44,12 @@
[% IF ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) %]
<li><a href="/cgi-bin/koha/tools/picture-upload.pl">Upload patron images</a></li>
[% END %]
</ul>
[% END %]
[% IF ( CAN_user_tools_items_batchdel || CAN_user_tools_items_batchmod || CAN_user_tools_records_batchdel || CAN_user_tools_records_batchmod || CAN_user_tools_export_catalog || CAN_user_tools_inventory || CAN_user_tools_label_creator || CAN_user_tools_rotating_collections || ( CAN_user_stockrotation_manage_rotas && Koha.Preference('StockRotation') ) || CAN_user_tools_marc_modification_templates || CAN_user_tools_stage_marc_import || CAN_user_tools_manage_staged_marc || CAN_user_tools_upload_local_cover_images ) %]
<h5>Catalog</h5>
<ul>
</ul>
[% END %]
[% IF ( CAN_user_tools_items_batchdel || CAN_user_tools_items_batchmod || CAN_user_tools_records_batchdel || CAN_user_tools_records_batchmod || CAN_user_tools_export_catalog || CAN_user_tools_inventory || CAN_user_tools_label_creator || CAN_user_tools_rotating_collections || ( CAN_user_stockrotation_manage_rotas && Koha.Preference('StockRotation') ) || CAN_user_tools_marc_modification_templates || CAN_user_tools_stage_marc_import || CAN_user_tools_manage_staged_marc || CAN_user_tools_upload_local_cover_images ) %]
<h5>Catalog</h5>
<ul>
[% IF ( CAN_user_tools_items_batchdel ) %]
<li><a href="/cgi-bin/koha/tools/batchMod.pl?del=1">Batch item deletion</a></li>
[% END %]
@ -93,11 +94,12 @@
[% IF ( CAN_user_tools_upload_local_cover_images ) %]
<li><a href="/cgi-bin/koha/tools/upload-cover-image.pl">Upload local cover image</a></li>
[% END %]
</ul>
[% END %]
[% IF ( CAN_user_tools_edit_calendar || CAN_user_tools_manage_csv_profiles || CAN_user_tools_view_system_logs || CAN_user_tools_edit_additional_contents || CAN_user_tools_schedule_tasks || CAN_user_tools_edit_quotes || ( plugins_enabled && CAN_user_plugins_tool ) || CAN_user_tools_upload_general_files || CAN_user_tools_access_files ) %]
<h5>Additional tools</h5>
<ul>
</ul>
[% END %]
[% IF ( CAN_user_tools_edit_calendar || CAN_user_tools_manage_csv_profiles || CAN_user_tools_view_system_logs || CAN_user_tools_edit_additional_contents || CAN_user_tools_schedule_tasks || CAN_user_tools_edit_quotes || ( plugins_enabled && CAN_user_plugins_tool ) || CAN_user_tools_upload_general_files || CAN_user_tools_access_files ) %]
<h5>Additional tools</h5>
<ul>
[% IF ( CAN_user_tools_edit_calendar ) %]
<li><a href="/cgi-bin/koha/tools/holidays.pl">Calendar</a></li>
[% END %]
@ -130,6 +132,7 @@
[% IF ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports ) %]
<li><a href="/cgi-bin/koha/tools/problem-reports.pl">OPAC problem reports</a></li>
[% END %]
</ul>
[% END %]
</div></div>
</ul>
[% END %]
</div>
</div>

View file

@ -27,22 +27,27 @@
<h1>Tools</h1>
<div class="row">
<div class="col-sm-4">
[% IF ( CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_edit_notice_status_triggers || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_batch_extend_due_dates || CAN_user_tools_moderate_tags || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) ) %]
<h3>Patrons and circulation</h3>
[% END %]
<dl>
[% IF ( CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_edit_notice_status_triggers || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_batch_extend_due_dates || CAN_user_tools_moderate_tags || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) ) %]
<h3>Patrons and circulation</h3>
[% END %]
<dl>
[% IF (CAN_user_tools_manage_patron_lists) %]
<dt><a href="/cgi-bin/koha/patron_lists/lists.pl">Patron lists</a>
<dt><a href="/cgi-bin/koha/patron_lists/lists.pl">Patron lists</a></dt>
<dd>Manage lists of patrons</dd>
[% END %]
[% IF (CAN_user_clubs) %]
<dt><a href="/cgi-bin/koha/clubs/clubs.pl">Patron clubs</a>
<dt><a href="/cgi-bin/koha/clubs/clubs.pl">Patron clubs</a></dt>
<dd>Manage patron clubs</dd>
[% END %]
[% IF ( CAN_user_tools_moderate_comments ) %]
<dt><a href="/cgi-bin/koha/reviews/reviewswaiting.pl">Comments</a> [% IF ( pendingcomments ) %]<span class="number_box"><a href="/cgi-bin/koha/reviews/reviewswaiting.pl">[% pendingcomments | html %]</a></span>[% END %]</dt>
<dt>
<a href="/cgi-bin/koha/reviews/reviewswaiting.pl">Comments</a>
[% IF ( pendingcomments ) %]
<span class="number_box"><a href="/cgi-bin/koha/reviews/reviewswaiting.pl">[% pendingcomments | html %]</a></span>
[% END %]
</dt>
<dd>Moderate patron comments</dd>
[% END %]
@ -82,7 +87,12 @@
[% END %]
[% IF ( CAN_user_tools_moderate_tags ) %]
<dt><a href="/cgi-bin/koha/tags/review.pl">Tags</a> [% IF ( pendingtags ) %]<span class="number_box"><a href="/cgi-bin/koha/tags/review.pl">[% pendingtags | html %]</a></span>[% END %]</dt>
<dt>
<a href="/cgi-bin/koha/tags/review.pl">Tags</a>
[% IF ( pendingtags ) %]
<span class="number_box"><a href="/cgi-bin/koha/tags/review.pl">[% pendingtags | html %]</a></span>
[% END %]
</dt>
<dd>Moderate patron tags</dd>
[% END %]
@ -90,16 +100,14 @@
<dt><a href="/cgi-bin/koha/tools/picture-upload.pl">Upload patron images</a></dt>
<dd>Upload patron images in a batch or one at a time</dd>
[% END %]
</dl>
</div>
</div>
<div class="col-sm-4 col-sm-push-4">
[% IF ( CAN_user_tools_edit_calendar || CAN_user_tools_manage_csv_profiles || CAN_user_tools_view_system_logs || CAN_user_tools_edit_additional_contents || CAN_user_tools_schedule_tasks || CAN_user_tools_edit_quotes || ( plugins_enabled && CAN_user_plugins_tool ) || CAN_user_tools_upload_general_files || CAN_user_tools_access_files ) %]
<h3>Additional tools</h3>
[% END %]
<dl>
<div class="col-sm-4 col-sm-push-4">
[% IF ( CAN_user_tools_edit_calendar || CAN_user_tools_manage_csv_profiles || CAN_user_tools_view_system_logs || CAN_user_tools_edit_additional_contents || CAN_user_tools_schedule_tasks || CAN_user_tools_edit_quotes || ( plugins_enabled && CAN_user_plugins_tool ) || CAN_user_tools_upload_general_files || CAN_user_tools_access_files ) %]
<h3>Additional tools</h3>
[% END %]
<dl>
[% IF ( CAN_user_tools_edit_calendar ) %]
<dt><a href="/cgi-bin/koha/tools/holidays.pl">Calendar</a></dt>
<dd>Define days when the library is closed</dd>
@ -167,28 +175,25 @@
<dd>Manage OPAC problem reports submitted by patrons</dd>
[% END %]
</dl>
[% IF ( Koha.Preference('UseCashRegisters') && ( CAN_user_cash_management_cashup || CAN_user_cash_management_anonymous_refund ) ) %]
<h3>Cash management</h3>
<dl>
</dl>
[% IF ( Koha.Preference('UseCashRegisters') && ( CAN_user_cash_management_cashup || CAN_user_cash_management_anonymous_refund ) ) %]
<h3>Cash management</h3>
<dl>
<dt><a href="/cgi-bin/koha/pos/registers.pl">Cash summary for [% Branches.GetLoggedInBranchname | html %]</a></dt>
<dd>View cash takings for the current library</dd>
<dt><a href="/cgi-bin/koha/pos/register.pl">Transaction history for [% Registers.session_register_name | html %]</a></dt>
<dd>View transaction history for the current cash register</dd>
</dl>
[% END %]
</div>
</dl>
[% END %]
</div>
<div class="col-sm-4 col-sm-pull-4">
[% IF ( CAN_user_tools_items_batchdel || CAN_user_tools_items_batchmod || CAN_user_tools_records_batchdel || CAN_user_tools_records_batchmod || CAN_user_tools_export_catalog || CAN_user_tools_inventory || CAN_user_tools_label_creator || CAN_user_tools_rotating_collections || ( CAN_user_stockrotation_manage_rotas && Koha.Preference('StockRotation') ) || CAN_user_tools_marc_modification_templates || CAN_user_tools_stage_marc_import || CAN_user_tools_manage_staged_marc || CAN_user_tools_upload_local_cover_images ) %]
<h3>Catalog</h3>
[% END %]
<dl>
<div class="col-sm-4 col-sm-pull-4">
[% IF ( CAN_user_tools_items_batchdel || CAN_user_tools_items_batchmod || CAN_user_tools_records_batchdel || CAN_user_tools_records_batchmod || CAN_user_tools_export_catalog || CAN_user_tools_inventory || CAN_user_tools_label_creator || CAN_user_tools_rotating_collections || ( CAN_user_stockrotation_manage_rotas && Koha.Preference('StockRotation') ) || CAN_user_tools_marc_modification_templates || CAN_user_tools_stage_marc_import || CAN_user_tools_manage_staged_marc || CAN_user_tools_upload_local_cover_images ) %]
<h3>Catalog</h3>
[% END %]
<dl>
[% IF ( CAN_user_tools_items_batchdel ) %]
<dt><a href="/cgi-bin/koha/tools/batchMod.pl?del=1">Batch item deletion</a></dt>
<dd>Delete a batch of items</dd>
@ -268,10 +273,8 @@
<dt><a href="/cgi-bin/koha/tools/upload-cover-image.pl">Upload local cover image</a></dt>
<dd>Utility to upload scanned cover images for display in OPAC</dd>
[% END %]
</dl>
</div>
</div>
</dl>
</div>
</div>
[% INCLUDE 'intranet-bottom.inc' %]