Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 8175 - check logs error or displays incorrectly in details.pl

Browse source 
Changed "$item->{'materials'} ne ''" to
"defined($item->{'materials'}) && $item->{'materials'} =~ /\S/"
in if condition to prevent error when it is NULL, and to
properly capture the intent of printing if there is something
visible.

Cases tested include NULL, '0', '', ' ', and 'blah' by using
 UPDATE items SET materials=NULL where biblionumber=19158;
where the biblionumber was chosen randomly, because only NULL
was in the items.materials field. The NULL case triggers an
error, but it does display correctly.

The ' ' case displays an apparently empty column, which does not
seem to be the intent of the flag that is being set. This is why
a simple $var check is not sufficient.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This commit is contained in:
Mark Tompsett 2012-09-02 20:46:03 +08:00 committed by Paul Poulain
parent caec1ddfa4
commit b8f4b1fa14
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
catalogue/detail.pl
View file

@ -263,7 +263,7 @@ foreach my $item (@items) {
$analytics_flag=1; $analytics_flag=1;
$item->{countanalytics} = $countanalytics; $item->{countanalytics} = $countanalytics;
} }
if ($item->{'materials'} ne ''){ if (defined($item->{'materials'}) && $item->{'materials'} =~ /\S/){
$materials_flag = 1; $materials_flag = 1;
} }
push @itemloop, $item; push @itemloop, $item;