Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12532: Fix test

Browse source 
The mock was working. The problem was that the to_address of the notice
was set from the previous send.

A fix would be to update the message, but it seems better to simply
re-enqueue it.

This patch also use Koha::Notice::Messages.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Jonathan Druart 2023-09-19 11:14:42 +02:00 committed by Tomas Cohen Arazi
parent 273440924d
commit b9325a9177
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
t/db_dependent/Letters.t
View file

@ -982,7 +982,7 @@ subtest 'Test SMS handling in SendQueuedMessages' => sub {
subtest 'Test guarantor handling in SendQueuedMessages' => sub {
plan tests => 8;
plan tests => 7;
t::lib::Mocks::mock_preference( 'borrowerRelationship', 'test' );
@ -1037,18 +1037,18 @@ subtest 'Test guarantor handling in SendQueuedMessages' => sub {
is( $email_object->email->header('Cc'), $guarantor2->email, "cc correctly uses second guarantor" );
# feature disabled
t::lib::Mocks::mock_preference( 'RedirectGuaranteeEmail', '0' ); #FIXME: This mock is failing!?
t::lib::Mocks::mock_preference( 'RedirectGuaranteeEmail', '0' );
# reset message
$schema->resultset('MessageQueue')->search( { borrowernumber => $borrowernumber, status => 'sent' } )
->update( { status => 'pending', failure_code => undef } );
Koha::Notice::Messages->find($message_id)->delete;
$message_id = C4::Letters::EnqueueLetter($my_message);
warning_like { C4::Letters::SendQueuedMessages(); }
qr|No 'to_address', email address or guarantors email address for borrowernumber|,
"SendQueuedMessages fails when no to_address, patron notice email and RedirectGuaranteeEmail is not set";
# clear borrower queue
$schema->resultset('MessageQueue')->search( { borrowernumber => $borrowernumber, status => 'sent' } )->delete();
Koha::Notice::Messages->find($message_id)->delete;
};
subtest 'get_item_content' => sub {