Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32399: Remove FK constraints while changing columns

Browse source 
Some users have reported that the dbrev of bug 30483 fails. This might
depend on bad data, SQL server version, etc.
We now remove the constraints temporarily.

Test plan:
Reset your version in order to pass this dbrev again. So below
22.06.00.041.
* update systempreferences set value='22.0600040' where variable = 'Version';
Run updatedatabase.

Bonus: Create an issues record with invalid itemnumber (set FK check
off when doing so). Verify that dbrev fails and installer stops.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2022-12-05 09:18:04 +00:00 committed by Tomas Cohen Arazi
parent aa13c1a9d1
commit bad638578b
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
installer/data/mysql/db_revs/220600041.pl
View file

@ -6,10 +6,36 @@ return {
up => sub { up => sub {
my ($args) = @_; my ($args) = @_;
my ($dbh, $out) = @$args{qw(dbh out)}; my ($dbh, $out) = @$args{qw(dbh out)};
# Count bad records (expecting zero..)
my ( $cnt ) = $dbh->selectrow_array(q{
SELECT COUNT(issue_id) FROM issues
LEFT JOIN borrowers USING (borrowernumber)
LEFT JOIN items USING (itemnumber)
WHERE items.itemnumber IS NULL OR borrowers.borrowernumber IS NULL });
# If we found bad records, we will not continue
if( $cnt ) {
say $out "ERROR: Your issues table contains $cnt records violating foreign key constraints to the borrowers or items table.";
say $out "We recommend to remove them with a statement like:";
say $out " DELETE issues FROM issues LEFT JOIN borrowers bo USING (borrowernumber) WHERE bo.borrowernumber IS NULL;";
say $out " DELETE issues FROM issues LEFT JOIN items it USING (itemnumber) WHERE it.itemnumber IS NULL;";
die "Interrupting installer process: database revision for bug 30483 fails!";
}
# Green zone: remove FK constraints while changing columns (needed for some SQL server versions)
if( foreign_key_exists('issues', 'issues_ibfk_1') ) {
$dbh->do( q|ALTER TABLE issues DROP FOREIGN KEY issues_ibfk_1| );
}
if( foreign_key_exists('issues', 'issues_ibfk_2') ) {
$dbh->do( q|ALTER TABLE issues DROP FOREIGN KEY issues_ibfk_2| );
}
$dbh->do(q{ $dbh->do(q{
ALTER TABLE issues ALTER TABLE issues
MODIFY COLUMN borrowernumber int(11) NOT NULL COMMENT 'foreign key, linking this to the borrowers table for the patron this item was checked out to', MODIFY COLUMN borrowernumber int(11) NOT NULL COMMENT 'foreign key, linking this to the borrowers table for the patron this item was checked out to',
MODIFY COLUMN itemnumber int(11) NOT NULL COMMENT 'foreign key, linking this to the items table for the item that was checked out' MODIFY COLUMN itemnumber int(11) NOT NULL COMMENT 'foreign key, linking this to the items table for the item that was checked out'
}); });
$dbh->do( q|ALTER TABLE issues ADD CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE RESTRICT ON UPDATE CASCADE| );
$dbh->do( q|ALTER TABLE issues ADD CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE RESTRICT ON UPDATE CASCADE| );
}, },
}; };