From bb796fcf2e9f5b26d75315d8919b1ebbd43a4664 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer@bsz-bw.de>
Date: Fri, 17 Mar 2023 09:53:13 +0000
Subject: [PATCH] Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is not "Expected".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late and claim one of them
    * Make sure you have several Arrived issues
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has a different status than "Expected"
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/modules/serials/serials-edit.tt   | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
index 1a4d2e96e6..8c5ba5d8db 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
@@ -170,6 +170,27 @@ $(document).ready(function() {
             [% ELSE %]
               <option value="2">Arrived</option>
             [% END %]
+            [% IF ( serialslis.status21 ) %]
+              <option value="21" selected="selected">Circulating</option>
+            [% ELSE %]
+                [% IF ( !serialslis.status1 ) %]
+                    <option value="21">Circulating</option>
+                [% END %]
+            [% END %]
+            [% IF ( serialslis.status22 ) %]
+              <option value="22" selected="selected">Out for binding</option>
+            [% ELSE %]
+                [% IF ( !serialslis.status1 ) %]
+                    <option value="22">Out for binding</option>
+                [% END %]
+            [% END %]
+            [% IF ( serialslis.status23 ) %]
+              <option value="23" selected="selected">Bound</option>
+            [% ELSE %]
+                [% IF ( !serialslis.status1 ) %]
+                    <option value="23">Bound</option>
+                [% END %]
+            [% END %]
             [% IF ( serialslis.status3 ) %]
               <option value="3" selected="selected">Late</option>
             [% ELSE %]