Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31005: Don't inlcude attributes only required for other categories

Browse source 
To test:
 1 - Create a new patron attribute - check boxes to make it mandatory and visible etc.
 2 - Limit it to 'Patron' or other category
 3 - Edit a patron not in that category
 4 - Attempt to save
 5 - 500 Error
 6 - Missing mandatory extended attribute (type=MAND)
 7 - Apply patch
 8 - Attempt aedit again
 9 - It succeeds!
10 - Edit a patron in the category with MAND required
11 - on the edit page, right click teh attribute - click 'delete node'
12 - Submit the form
13 - 500 error, but this time that's good, the attribute check works

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2022-06-23 17:29:26 +00:00 committed by Tomas Cohen Arazi
parent 39c3943076
commit bc0264bae4
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Koha/Patron.pm
View file

@ -1707,8 +1707,9 @@ sub extended_attributes {
Koha::Patron::Attribute::Types->search(
{
mandatory => 1,
category_code => [ undef, $self->categorycode ],
'borrower_attribute_types_branches.b_branchcode' =>
undef
undef,
},
{ join => 'borrower_attribute_types_branches' }
)->get_column('code');