Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32975: Error in package.json's definition of css:build vs css:build:prod

Browse source 
The "css:build" command runs "gulp css && gulp css --view opac",
processes that build CSS in a development context.

The "css:build:prod" currently runs "gulp build && gulp css --view
opac", which runs the production-oriented command "gulp build" (for the
staff interface), but runs "gulp css --view opac" which is the same
devel-environment command as above.

It should be "gulp build && gulp build --view opac"

To test, apply the patch and run the two commands and check these two
files to confirm the difference:

koha-tmpl/intranet-tmpl/prog/css/staff-global.css
koha-tmpl/opac-tmpl/bootstra/css/opac.css

"yarn css:build" should create unminimized versions of those files.
"yarn css:build:prod" should create minimized versions.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-02-15 18:19:14 +00:00 committed by Tomas Cohen Arazi
parent a9743888e5
commit bc43c6e7fe
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -41,7 +41,7 @@
},
"scripts": {
"css:build": "gulp css && gulp css --view opac",
"css:build:prod": "gulp build && gulp css --view opac",
"css:build:prod": "gulp build && gulp build --view opac",
"css:watch": "gulp watch",
"js:build": "webpack --mode development",
"js:watch": "webpack --mode development --watch",