Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses

Browse source 
(see bug 28010) Use plugin call pattern established in bug 28211.

Please utilize version 1.0.1 of the plugin to test this follow-up:
https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Pedro Amorim 2023-11-15 15:26:33 +00:00 committed by Katrin Fischer
parent e370b6698e
commit bcdbc68d9a
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Koha/Illrequest.pm
View file

@ -2083,10 +2083,7 @@ sub get_staff_table_actions {
}
];
my @plugin_responses = Koha::Plugins->call('ill_table_actions');
for my $plugin_variables (@plugin_responses) {
push( @{$ill_table_actions}, $plugin_variables );
}
Koha::Plugins->call( 'ill_table_actions', \$ill_table_actions );
return $ill_table_actions;
}

17
t/lib/plugins/Koha/Plugin/Test.pm
View file

@ -378,14 +378,17 @@ sub template_include_paths {
}
sub ill_table_actions {
my ( $self ) = @_;
my ( $self, $table_actions ) = @_;
return {
button_link_text => 'Test text',
append_column_data_to_link => 1,
button_class => 'test class',
button_link => 'test link'
};
push(
@{$$table_actions},
{
button_link_text => 'Test text',
append_column_data_to_link => 1,
button_class => 'test class',
button_link => 'test link'
}
);
}
sub _private_sub {