From bf22d5209889591b6447a3921b139397f06b9e00 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 15 Feb 2024 18:02:02 +0000
Subject: [PATCH] Bug 34478: Classification config - Convert delete links to
 form POSTS

This patch converts the delete links on the classification
configuration page for sources, filing rules, and splitting rules to
POST forms.

A couple of op checks in the script are corrected to match.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 admin/classsources.pl                         |  6 ++---
 .../prog/en/modules/admin/classsources.tt     | 22 ++++++++++++++++---
 2 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/admin/classsources.pl b/admin/classsources.pl
index 65a55d5b88..53aa3252c1 100755
--- a/admin/classsources.pl
+++ b/admin/classsources.pl
@@ -109,7 +109,7 @@ elsif ( $op eq "cud-add_source_validate" ) {
 
     $op = 'list';
 }
-elsif ( $op eq "delete_source_confirmed" ) {
+elsif ( $op eq "cud-delete_source_confirmed" ) {
     my $class_source = Koha::ClassSources->find($cn_source);
     my $deleted = eval { $class_source->delete };
     if ( $@ or not $deleted ) {
@@ -166,7 +166,7 @@ elsif ( $op eq "cud-add_sort_rule_validate" ) {
     }
     $op = 'list';
 }
-elsif ( $op eq "delete_sort_rule" ) {
+elsif ( $op eq "cud-delete_sort_rule" ) {
     my $sort_rule = Koha::ClassSortRules->find($class_sort_rule);
     my $deleted = eval { $sort_rule->delete };
     if ( $@ or not $deleted ) {
@@ -237,7 +237,7 @@ elsif ( $op eq "cud-add_split_rule_validate" ) {
     }
     $op = 'list';
 }
-elsif ( $op eq "delete_split_rule" ) {
+elsif ( $op eq "cud-delete_split_rule" ) {
     my $split_rule = Koha::ClassSplitRules->find($class_split_rule);
     my $deleted = eval { $split_rule->delete };
     if ( $@ or not $deleted ) {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
index 52db26d482..5ed97a5bdd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
@@ -357,7 +357,12 @@
     <td>[% class_source.class_split_rule | html %]</td>
     <td class="actions">
       <a class="btn btn-default btn-xs" href="[% script_name | url %]?op=add_source&amp;cn_source=[% class_source.cn_source | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
-      <a class="btn btn-default btn-xs delete_class_source" href="[% script_name | url %]?op=delete_source_confirmed&amp;cn_source=[% class_source.cn_source | uri%]"><i class="fa fa-trash-can"></i> Delete</a>
+        <form action="[% script_name | url %]" method="post">
+            [% INCLUDE 'csrf-token.inc' %]
+            <input type="hidden" name="op" value="cud-delete_source_confirmed" />
+            <input type="hidden" name="cn_source" value="[% class_source.cn_source | uri%]" />
+            <button class="btn btn-default btn-xs delete_class_source"><i class="fa fa-trash-can"></i> Delete</button>
+        </form>
     </td>
   </tr>
   [% END %]
@@ -380,7 +385,12 @@
     <td>[% rule.sort_routine | html %]</td>
     <td class="actions">
       <a class="btn btn-default btn-xs" href="[% script_name | html %]?op=add_sort_rule&amp;class_sort_rule=[% rule.class_sort_rule |url %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
-      <a class="btn btn-default btn-xs delete_sort_rule" href="[% script_name | html %]?op=delete_sort_rule&amp;class_sort_rule=[% rule.class_sort_rule |url %]"><i class="fa fa-trash-can"></i> Delete</a>
+        <form action="[% script_name | url %]" method="post">
+            [% INCLUDE 'csrf-token.inc' %]
+            <input type="hidden" name="op" value="cud-delete_sort_rule" />
+            <input type="hidden" name="class_sort_rule" value="[% rule.class_sort_rule |url %]" />
+            <button class="btn btn-default btn-xs delete_class_source"><i class="fa fa-trash-can"></i> Delete</button>
+        </form>
     </td>
   </tr>
   [% END %]
@@ -403,7 +413,13 @@
     <td>[% rule.split_routine | html %]</td>
     <td class="actions">
       <a class="btn btn-default btn-xs" href="[% script_name | url %]?op=add_split_rule&amp;class_split_rule=[% rule.class_split_rule | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
-      <a class="btn btn-default btn-xs delete_split_rule" href="[% script_name | url %]?op=delete_split_rule&amp;class_split_rule=[% rule.class_split_rule | uri %]"><i class="fa fa-trash-can"></i> Delete</a>
+        <form action="[% script_name | url %]" method="post">
+            [% INCLUDE 'csrf-token.inc' %]
+            <input type="hidden" name="op" value="cud-delete_split_rule" />
+            <input type="hidden" name="class_split_rule" value="[% rule.class_split_rule | html %]" />
+            <input type="hidden" name="op" value="cud-delete_split_rule" />
+            <button class="btn btn-default btn-xs delete_split_rule"><i class="fa fa-trash-can"></i> Delete</button>
+        </form>
     </td>
   </tr>
   [% END %]