Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 20310: Adding a pref to control behavior

Browse source 
If people want to control the redirection, we could add a pref
like ArticleRequestsHostRedirection. If it is not enabled,
the party is over.

Test plan:
Test if redirection stops on a child and host when you disable.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marcel de Rooy 2020-09-08 13:29:45 +00:00 committed by Jonathan Druart
parent 1f8d0a8fe5
commit bf5ed39364
5 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Koha/Biblio.pm
View file

@ -910,6 +910,7 @@ sub host_record {
my ($self, $params) = @_;
my $no_items = $params->{no_items};
return if C4::Context->preference('marcflavour') eq 'UNIMARC'; # TODO
return if !C4::Context->preference('ArticleRequestsHostRedirection');
return if $params->{no_items} && $self->items->count > 0;
my $record;

8
installer/data/mysql/atomicupdate/bug_20130.perl Normal file
View file

@ -0,0 +1,8 @@
$DBversion = 'XXX'; # will be replaced by the RM
if( CheckVersion( $DBversion ) ) {
$dbh->do(q{
INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
('ArticleRequestsHostRedirection', '0', NULL, 'Enables redirection from child to host', 'YesNo')
});
NewVersion( $DBversion, 20310, "Add pref ArticleRequestsHostRedirection");
}

1
installer/data/mysql/mandatory/sysprefs.sql
View file

@ -56,6 +56,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
('AnonSuggestions','0',NULL,'Set to enable Anonymous suggestions to AnonymousPatron borrowernumber','YesNo'),
('AnonymousPatron','0',NULL,'Set the identifier (borrowernumber) of the anonymous patron. Used for suggestion and checkout history privacy',''),
('ArticleRequests', '0', NULL, 'Enables the article request feature', 'YesNo'),
('ArticleRequestsHostRedirection', '0', NULL, 'Enables redirection from child to host', 'YesNo'),
('ArticleRequestsLinkControl', 'calc', 'always|calc', 'Control display of article request link on search results', 'Choice'),
('ArticleRequestsMandatoryFields', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''yes''', 'multiple'),
('ArticleRequestsMandatoryFieldsItemOnly', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''item_only''', 'multiple'),

6
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
View file

@ -1192,6 +1192,12 @@ Circulation:
1: Enable
0: "Don't enable"
- patrons to place article requests.
-
- pref: ArticleRequestsHostRedirection
choices:
yes: Enable
no: Disable
- " redirection from child to host based on MARC21 773$w when the child has no items."
-
- pref: ArticleRequestsLinkControl
choices:

1
t/db_dependent/Koha/Biblio/host_record.t
View file

@ -40,6 +40,7 @@ subtest 'host_record' => sub {
t::lib::Mocks::mock_preference( 'marcflavour', 'MARC21' );
t::lib::Mocks::mock_preference( 'MARCOrgCode', 'xyz' );
t::lib::Mocks::mock_preference( 'ArticleRequestsHostRedirection', 1 );
my $bib1 = $builder->build_object({ class => 'Koha::Biblios' });
my $bib2 = $builder->build_object({ class => 'Koha::Biblios' });