Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32804: (QA follow-up) Typo ahs and fix ImportBatch.t

Browse source 
Resolve:
    #   Failed test 'Item's biblioitemnumber has not changed'
    #   at t/db_dependent/ImportBatch.t line 407.
    #
    #          got: '4261'
    #     expected: '2371'

Do not compare $item1->biblionumber with $original_biblioitemnumber :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2023-03-17 08:43:32 +00:00 committed by Tomas Cohen Arazi
parent 520db70bf1
commit bf8e0a394f
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/ImportBatch.pm
View file

@ -799,7 +799,7 @@ sub _batchCommitItems {
$updsth->finish();
$num_items_replaced++;
} elsif (
# We aren't replacing, but the incoming file ahs a barcode, we need to check if it exists
# We aren't replacing, but the incoming file has a barcode, we need to check if it exists
$duplicate_barcode &&
( $item_match = Koha::Items->find({ barcode => $item->{'barcode'} }) )
) {

2
t/db_dependent/ImportBatch.t
View file

@ -404,7 +404,7 @@ subtest "Do not adjust biblionumber when replacing items during import" => sub {
is( $import_item->import_error, undef, 'No error was reported' );
is( $item1->biblionumber, $original_biblionumber, "Item's biblionumber has not changed" );
is( $item1->biblionumber, $original_biblioitemnumber, "Item's biblioitemnumber has not changed" );
is( $item1->biblioitemnumber, $original_biblioitemnumber, "Item's biblioitemnumber has not changed" );
is( $item1->homebranch, $library->branchcode, "Item was overlaid successfully" );
};