Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15496: (QA follow-up) Fix new uses of Koha::Biblio::items in list context

Browse source 
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Nick Clemens 2019-04-26 12:04:57 +00:00
parent bf473396ab
commit bfce1fea96
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/ILSDI/Services.pm
View file

@ -230,7 +230,7 @@ sub GetRecords {
my $biblioitemnumber = $biblioitem->{'biblioitemnumber'};
my $holds = $biblio->current_holds->unblessed;
my $issues = GetBiblioIssues($biblionumber);
my @items = $biblio->items;
my @items = $biblio->items->as_list;
$biblioitem->{items}->{item} = [];

6
Koha/Biblio.pm
View file

@ -154,7 +154,7 @@ sub can_be_transferred {
my $limittype = C4::Context->preference('BranchTransferLimitsType');
my $items;
foreach my $item_of_bib ($self->items) {
foreach my $item_of_bib ($self->items->as_list) {
next unless $item_of_bib->holdingbranch;
next if $from && $from->branchcode ne $item_of_bib->holdingbranch;
return 1 if $item_of_bib->holdingbranch eq $to->branchcode;
@ -207,7 +207,7 @@ sub hidden_in_opac {
my $rules = $params->{rules} // {};
return !(any { !$_->hidden_in_opac({ rules => $rules }) } $self->items);
return !(any { !$_->hidden_in_opac({ rules => $rules }) } $self->items->as_list);
}
=head3 article_request_type
@ -457,7 +457,7 @@ sub has_items_waiting_or_intransit {
return 1;
}
foreach my $item ( $self->items ) {
foreach my $item ( $self->items->as_list ) {
return 1 if $item->get_transfer;
}

2
t/db_dependent/Koha/Biblio.t
View file

@ -101,7 +101,7 @@ subtest 'items() tests' => sub {
is( ref($items), 'Koha::Items', 'Returns a Koha::Items resultset' );
is( $items->count, 2, 'Two items in resultset' );
my @items = $biblio->items;
my @items = $biblio->items->as_list;
is( scalar @items, 2, 'Same result, but in list context' );
$schema->storage->txn_rollback;