Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 6874: QA follow-up

Browse source 
Squash of the following commits:
  return with explicit undef removed
  Follow-up for PBP fixes
  follow-up fix POD syntax
  follow-up jquery has moved

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended: removed POD changes in Biblio.pm while rebasing.
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
This commit is contained in:
Paul Poulain 2013-03-19 10:48:08 +01:00 committed by Tomas Cohen Arazi
parent 2def11d678
commit bfe5680186
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/UploadedFiles.pm
View file

@ -180,7 +180,7 @@ sub UploadFile {
return $id;
}
return undef;
return;
}
=head2 DelUploadedFile

2
cataloguing/value_builder/upload.pl
View file

@ -140,7 +140,7 @@ sub finddirs {
my $base = shift || $upload_path;
my $found = 0;
my @dirs;
my @files = <$base/*>;
my @files = glob("$base/*");
foreach (@files) {
if (-d $_ and -w $_) {
my $lastdirname = basename($_);

2
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload.tt
View file

@ -4,7 +4,7 @@
<head>
<title>Upload plugin</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<script type="text/javascript" src="[% themelang %]/lib/jquery/jquery.js"></script>
<script type="text/javascript" src="/intranet-tmpl/lib/jquery/jquery.js"></script>
<link rel="stylesheet" type="text/css" href="[% themelang %]/css/staff-global.css" />
</head>

4
opac/opac-retrieve-file.pl
View file

@ -32,12 +32,12 @@ exit 1 if not $file;
my $file_path = $file->{filepath};
if( -f $file_path ) {
open FH, '<', $file_path or die "Can't open file: $!";
open my $fh, '<', $file_path or die "Can't open file: $!";
print $input->header(
-type => "application/octet-stream",
-attachment => $file->{filename}
);
while(<FH>) {
while(<$fh>) {
print $_;
}
} else {