Bug 10956 - Series of OPAC searches can cause a browser crash
This patch fixes the issue for bootstrap. It was earlier fixed for the prog theme. Solution: Prevent jQuery.fn.highlight = function(pat) to be called with empty pat by skipping empty values in highlight loop. To test: Without patch, do a search as in comment #1 odr #3 Result: Endless loop (Script not responding) Appply patch: No endless loop, page displays OK Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> To reproduce you need to search a string with 2 spaces. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I didn't manage to reproduce the problem, but I couldn't find any regression either trying multiple searches. Trusting Marc's and Jonathan's testing. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
parent
b4c0eb4a51
commit
c087027487
1 changed files with 9 additions and 7 deletions
|
@ -1354,13 +1354,15 @@
|
|||
function highlightOn() {
|
||||
var x;
|
||||
for (x in q_array) {
|
||||
q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1");
|
||||
q_array[x] = q_array[x].toLowerCase();
|
||||
var myStopwords = "[% Koha.Preference('NotHighlightedWords') %]".toLowerCase().split('|');
|
||||
if( $.inArray(q_array[x], myStopwords) == -1 ) {
|
||||
$(".title").highlight(q_array[x]);
|
||||
$(".author").highlight(q_array[x]);
|
||||
$(".results_summary").highlight(q_array[x]);
|
||||
if ( q_array[x].length > 0 ) {
|
||||
q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1");
|
||||
q_array[x] = q_array[x].toLowerCase();
|
||||
var myStopwords = "[% Koha.Preference('NotHighlightedWords') %]".toLowerCase().split('|');
|
||||
if( $.inArray(q_array[x], myStopwords) == -1 ) {
|
||||
$(".title").highlight(q_array[x]);
|
||||
$(".author").highlight(q_array[x]);
|
||||
$(".results_summary").highlight(q_array[x]);
|
||||
}
|
||||
}
|
||||
}
|
||||
$(".highlight_toggle").toggle();
|
||||
|
|
Loading…
Reference in a new issue