Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 10956 - Series of OPAC searches can cause a browser crash

Browse source 
This patch fixes the issue for bootstrap. It was earlier fixed for the prog theme.

Solution: Prevent  jQuery.fn.highlight = function(pat) to be called with empty pat
by skipping empty values in highlight loop.

To test:
Without patch, do a search as in comment #1 odr #3
Result: Endless loop (Script not responding)

Appply patch:
No endless loop, page displays OK

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
To reproduce you need to search a string with 2 spaces.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I didn't manage to reproduce the problem, but I couldn't find
any regression either trying multiple searches.
Trusting Marc's and Jonathan's testing.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Marc Véron 2014-11-19 11:40:39 +01:00 committed by Tomas Cohen Arazi
parent b4c0eb4a51
commit c087027487
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
View file

@ -1354,6 +1354,7 @@
function highlightOn() {
var x;
for (x in q_array) {
if ( q_array[x].length > 0 ) {
q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1");
q_array[x] = q_array[x].toLowerCase();
var myStopwords = "[% Koha.Preference('NotHighlightedWords') %]".toLowerCase().split('|');
@ -1363,6 +1364,7 @@
$(".results_summary").highlight(q_array[x]);
}
}
}
$(".highlight_toggle").toggle();
}
[% END %]