Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 19361: (QA follow-up) Make sure "Not an authorised value" appears in the pull down

Browse source 
This is to make sure that the small icon with the additional tooltip
style explanation is not as easily missed.

Also updates text slightly:
* Pull downs: "X (Not an authorised value)"
* Tooltip: "The current value X is not configured for the authorised value category controlling this subfield"

Switches from exclamation triangle to the more "alerting" exclamation-triangle :)

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Katrin Fischer 2023-03-17 17:43:18 +00:00 committed by Tomas Cohen Arazi
parent e0880ed3c9
commit c123b41480
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
View file

@ -122,7 +122,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr
$node.append( '<option value="' + authval.value + '"' + selected + '>' + authval.lib + '</option>' );
} );
if( !matched ){
$node.append( "<option value='" + value + "' selected='selected'>" + value + " " + _("(Not in authorised values list)") + " " + "</option>" );
$node.append( "<option value='" + value + "' selected='selected'>" + value + " " + _("(Not an authorised value)") + " " + "</option>" );
}
$node.val( this.text );

4
koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
View file

@ -126,9 +126,9 @@
[% END %]
[% UNLESS matched || ( ( kohafield == 'items.damaged' || kohafield == 'items.itemlost' || kohafield == 'items.withdrawn' || kohafield == 'items.notforloan' ) && mv.default == '0' ) %]
[%# If the current value is not in the authorised list and is not a field where 0 means unset #%]
<option value="[%- mv.default | html -%]" selected="selected">[%- mv.default | html -%]</option>
<option value="[%- mv.default | html -%]" selected="selected">[%- mv.default | html -%] (Not an authorised value)</option>
</select>
<span style="float:right;" title="The current value [% mv.default | html %] is not in the authorised value list"><i class="fa fa-exclamation-circle" aria-hidden="true"></i></span>
<span style="float:right;" title="The current value [% mv.default | html %] is not configured for the authorised value category controlling this subfield"><i class="fa fa-exclamation-triangle" aria-hidden="true"></i></span>
[% ELSE %]
</select>
[% END %]

6
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
View file

@ -1159,10 +1159,10 @@ function PopupMARCFieldDoc(field) {
[% END %]
[% END %]
[% UNLESS matched # If the current value is not in the authorised list %]
<option value="[%- mv.default | html -%]" selected="selected">[%- mv.default | html -%]</option>
[% UNLESS matched # If the current value is not in the authorised value list %]
<option value="[%- mv.default | html -%]" selected="selected">[%- mv.default | html -%] (Not an authorised value)</option>
</select>
<span style="float:right;" title="The current value [% mv.default | html %] is not in the authorised value list"><i class="fa fa-exclamation-circle" aria-hidden="true"></i></span>
<span style="float:right;" title="The current value [% mv.default | html %] is not configured for the authorised value category controlling this subfield"><i class="fa fa-exclamation-triangle" aria-hidden="true"></i></span>
[% ELSE %]
</select>
[% END %]