Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 10767: (follow-up) remove FIXME comments

Browse source 
The FIXME comments in the new test script were based on
an assumption that GetIssuingRules() should return
multiple rules if no or only partial parameters are
passed.  This is not the intent of that routine, whose
purpose is to return the *singular* rule that best
applies to a given loan situation.  In other words,
GetIssuingRule() is not a traditional accessor function.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Galen Charlton 2013-08-28 14:44:01 +00:00
parent 08d45913d6
commit c191532cc0
1 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
t/db_dependent/Circulation_Issuingrule.t
View file

@ -279,15 +279,6 @@ is_deeply(
"GetIssuingCharge returns issuingrule1's informations"
);
#FIX ME: Currently, GetIssuingRule without parameters returns an issuingrule with branchcode -> *,categorycode -> *, itemtype -> *
#is_deeply ( GetIssuingRule(),{$sampleissuingrule1,$sampleissuingrule2,$sampleissuingrule3},"Without parameters, GetIssuingRule returns all the issuingrule");
#FIX ME: Currently, GetIssuingRule with only one parameter returns an issuingrule with branchcode -> *,categorycode -> *, itemtype -> *
#is_deeply(GetIssuingRule($samplecat->{categorycode}),{$sampleissuingrule1,$sampleissuingrule2,$sampleissuingrule3},"GetIssuingRule with a categorycode returns all the issuingrules of this category");
#FIX ME: Currently, GetIssuingRule with only two parameters returns an issuingrule with branchcode -> *,categorycode -> *, itemtype -> *
#is_deeply(GetIssuingRule($samplecat->{categorycode},'BOOK'),{$sampleissuingrule1,$sampleissuingrule2},"GetIssuingRule with a categorycode and'Book' returns all the issuingrules of this category and the itemtype = book");
#Test GetLoanLength
is_deeply(
C4::Circulation::GetLoanLength(
@ -346,12 +337,5 @@ is_deeply(
"GetHardDueDate returns the duedate and the duedatecompare"
);
#FIXME: Currently, with wrong parameters GetHardDueDate returns '' because GetIssuingrule returns wrong value
#@hardduedate = C4::Circulation::GetHardDueDate(-1,-1,-1);
#is_deeply(\@hardduedate,[undef,undef],"GetHardDueDate with wrong parameters returns undef");
#FIXME: Currently, without parameter GetHardDueDate returns '' because GetIssuingrule returns wrong value
#@hardduedate = C4::Circulation::GetHardDueDate();
#is_deeply(\@hardduedate,[undef,undef],"GetHardDueDate without parameter returns undef");
#End transaction
$dbh->rollback;