Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 24300: (QA follow-up) Update payout_amount to use internal methods

Browse source 
Tomas pointed out that we could, and probably should, use the internal
'add_debit' method within this function.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2021-03-17 14:12:37 +00:00 committed by Jonathan Druart
parent 1f32b62d1c
commit c2026b6624
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Koha/Account.pm
View file

@ -692,20 +692,18 @@ sub payout_amount {
sub { sub {
# A 'payout' is a 'debit' # A 'payout' is a 'debit'
$payout = Koha::Account::Line->new( $payout = $self->add_debit(
{ {
date => \'NOW()', amount => $params->{amount},
amount => $amount, type => 'PAYOUT',
debit_type_code => 'PAYOUT',
payment_type => $params->{payout_type}, payment_type => $params->{payout_type},
amountoutstanding => $amount, amountoutstanding => $params->{amount},
manager_id => $params->{staff_id}, manager_id => $params->{staff_id},
borrowernumber => $self->{patron_id},
interface => $params->{interface}, interface => $params->{interface},
branchcode => $params->{branch}, branchcode => $params->{branch},
register_id => $params->{cash_register} register_id => $params->{cash_register}
} }
)->store(); );
# Offset against credits # Offset against credits
for my $credit ( @{$outstanding_credits} ) { for my $credit ( @{$outstanding_credits} ) {