Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

[followup](bug #3667) cleaning borrowers fix

Browse source 
This fix GetBorrowersWhoHaveNotBorrowedSince to select only borrowers that have no issues and have no old_issues more recent than a specified date.
This commit is contained in:
Nahuel ANGELINETTI 2009-12-29 16:06:35 +01:00 committed by Henri-Damien LAURENT
parent 9d1e7f43e1
commit c2e245e2da
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
C4/Members.pm
View file

@ -1724,7 +1724,7 @@ Looks up the different title . Returns array with all borrowers title
=cut
sub GetTitles {
my @borrowerTitle = split /,|\|/,C4::Context->preference('BorrowersTitles');
my @borrowerTitle = split (/,|\|/,C4::Context->preference('BorrowersTitles'));
unshift( @borrowerTitle, "" );
my $count=@borrowerTitle;
if ($count == 1){
@ -1838,10 +1838,13 @@ sub GetBorrowersWhoHaveNotBorrowedSince {
: "");
my $dbh = C4::Context->dbh;
my $query = "
SELECT borrowers.borrowernumber,max(issues.timestamp) as latestissue
SELECT borrowers.borrowernumber,
max(old_issues.timestamp) as latestissue,
max(issues.timestamp) as currentissue
FROM borrowers
JOIN categories USING (categorycode)
LEFT JOIN issues ON borrowers.borrowernumber = issues.borrowernumber
LEFT JOIN old_issues USING (borrowernumber)
LEFT JOIN issues USING (borrowernumber)
WHERE category_type <> 'S'
";
my @query_params;
@ -1854,7 +1857,8 @@ sub GetBorrowersWhoHaveNotBorrowedSince {
}
$query.=" GROUP BY borrowers.borrowernumber";
if ($filterdate){
$query.=" HAVING latestissue <? OR latestissue IS NULL";
$query.=" HAVING (latestissue < ? OR latestissue IS NULL)
AND currentissue IS NULL";
push @query_params,$filterdate;
}
warn $query if $debug;