Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 11518: (follow-up) Change method name from 'itemtype' to 'effective_itemtype' for clarity

Browse source 
Test runs without errors.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Kyle Hall 2014-01-10 10:21:55 -05:00 committed by Galen Charlton
parent cef35259ee
commit c3c7105fe7
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/Schema/Result/Item.pm
View file

@ -625,7 +625,7 @@ __PACKAGE__->belongs_to(
);
use C4::Context;
sub itemtype {
sub effective_itemtype {
my ( $self ) = @_;
if ( C4::Context->preference('item-level_itypes') ) {

4
t/db_dependent/Items.t
View file

@ -170,10 +170,10 @@ subtest q{Test Koha::Database->schema()->resultset('Item')->itemtype()} => sub {
my ( $item ) = $biblioitem->items();
C4::Context->set_preference( 'item-level_itypes', 0 );
ok( $item->itemtype() eq 'BIB_LEVEL', '$item->itemtype() returns biblioitem.itemtype when item-level_itypes is disabled' );
ok( $item->effective_itemtype() eq 'BIB_LEVEL', '$item->itemtype() returns biblioitem.itemtype when item-level_itypes is disabled' );
C4::Context->set_preference( 'item-level_itypes', 1 );
ok( $item->itemtype() eq 'ITEM_LEVEL', '$item->itemtype() returns items.itype when item-level_itypes is disabled' );
ok( $item->effective_itemtype() eq 'ITEM_LEVEL', '$item->itemtype() returns items.itype when item-level_itypes is disabled' );
$dbh->rollback;