Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 20499: Unit Test to prove the problem

Browse source 
TEST PLAN
---------
1) apply this patch
2) prove t/db_dependent/Circulation.t
   -- horrible death.
3) apply next path
4) prove t/db_dependent/Circulation.t
   -- passes.
5) run koha qa test tools

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Mark Tompsett 2018-03-29 18:44:32 +00:00 committed by Jonathan Druart
parent 2a04fdbe60
commit c43af09eb4
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
t/db_dependent/Circulation.t
View file

@ -1193,7 +1193,7 @@ C4::Context->dbh->do("DELETE FROM accountlines");
}
subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
plan tests => 23;
plan tests => 24;
my $homebranch = $builder->build( { source => 'Branch' } );
my $holdingbranch = $builder->build( { source => 'Branch' } );
@ -1225,6 +1225,10 @@ subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
# AllowReturnToBranch == anywhere
t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
## Test that unknown barcodes don't generate internal server errors
set_userenv($homebranch);
( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
## Can be issued from homebranch
set_userenv($homebranch);
( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );