Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 24746: Duplicate id in opacheader markup

Browse source 
This patch removes '<div id="opacheader">' from masthead.inc
because the same markup is generated by koha_news_block.

To reproduce the bug, make sure there is an opacheader news block
defined. Add this to the OPACUserCSS system preference:

View the main page of the OPAC. You should see two blue borders around
the opacheader content.

Apply the patch and reload the OPAC page. There should now be only one
blue border.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; }
don't know the intended value but works :)

Work as described following test plan, no errors.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Owen Leonard 2020-02-27 02:06:34 +00:00 committed by Martin Renvoize
parent bd88b10c6f
commit c44bfe1208
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
View file

@ -150,9 +150,7 @@
[% IF ( OpacHeader ) %]
<div class="container-fluid">
<div class="row-fluid">
<div id="opacheader">
[% PROCESS koha_news_block news => OpacHeader %]
</div>
[% PROCESS koha_news_block news => OpacHeader %]
</div>
</div>
[% END %]