Browse Source

Bug 26605: Correctly URI-encode query string in call number browse plugin

If you search for a call number like "M KRUEGER CO #11" in the plugin, your query is cut off at "M KRUEGER CO " because
the hash isn't escaped, so the browser thinks you are opening a
window and trying to navigate to the element with the id 11 rather
than passing the #11 to the server.

To test:
1) Find the record you will use to test, determing the MARC
framework it uses by going to Edit > Edit record > Settings
2) In Administration > MARC bibliographic framework, click MARC
structure in the Actions menu for that framework
3) Navigate to the 952 tag, in the Actions menu click Edit subfields
4) In the tab for o, choose the Plugin and click
Save Changes
5) Click the Edit button next to one of the items on your record
6) In the Full call number field, add " CO #11" to the call number
7) Click the ... next to the field to open the Tag editor
8) In the popup window, verify that the search field includes the
" CO #11" you added to the call number

Signed-off-by: Chris Cormack <>

Signed-off-by: Katrin Fischer <>

Signed-off-by: Jonathan Druart <>
Phil Ringnalda 2 years ago
committed by Jonathan Druart
  1. 2


@ -36,7 +36,7 @@ my $builder = sub {
function Click$function_name(i) {
q = document.getElementById('$params->{id}');\"../cataloguing/\"+q.value,\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\");\"../cataloguing/\"+encodeURIComponent(q.value),\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\");