Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32986: (follow-up) Tidy conditional in letter.pl

Browse source 
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2023-07-14 12:47:29 +00:00 committed by Tomas Cohen Arazi
parent 6322e08a02
commit c53e6e977f
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 21 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
tools/letter.pl
View file

@ -240,35 +240,29 @@ sub add_form {
my $field_selection;
push @{$field_selection}, add_fields('branches');
if ($module eq 'reserves') {
push @{$field_selection}, add_fields('borrowers', 'reserves', 'biblio', 'biblioitems', 'items');
}
elsif ( $module eq 'acquisition' ) {
push @{$field_selection}, add_fields('aqbooksellers', 'aqorders', 'biblio', 'items');
}
elsif ($module eq 'claimacquisition' || $module eq 'orderacquisition') {
push @{$field_selection}, add_fields('aqbooksellers', 'aqbasket', 'aqorders', 'biblio', 'biblioitems');
}
elsif ($module eq 'claimissues') {
push @{$field_selection}, add_fields('aqbooksellers', 'serial', 'subscription', 'biblio', 'biblioitems');
}
elsif ( $module eq 'patron_slip' ) {
if ( $module eq 'reserves' ) {
push @{$field_selection}, add_fields( 'borrowers', 'reserves', 'biblio', 'biblioitems', 'items' );
} elsif ( $module eq 'acquisition' ) {
push @{$field_selection}, add_fields( 'aqbooksellers', 'aqorders', 'biblio', 'items' );
} elsif ( $module eq 'claimacquisition' || $module eq 'orderacquisition' ) {
push @{$field_selection}, add_fields( 'aqbooksellers', 'aqbasket', 'aqorders', 'biblio', 'biblioitems' );
} elsif ( $module eq 'claimissues' ) {
push @{$field_selection}, add_fields( 'aqbooksellers', 'serial', 'subscription', 'biblio', 'biblioitems' );
} elsif ( $module eq 'patron_slip' ) {
push @{$field_selection}, add_fields('borrowers');
}
elsif ($module eq 'serial') {
push @{$field_selection}, add_fields('branches', 'biblio', 'biblioitems', 'borrowers', 'subscription', 'serial');
}
elsif ($module eq 'suggestions') {
push @{$field_selection}, add_fields('suggestions', 'borrowers', 'biblio');
}
else {
push @{$field_selection}, add_fields('biblio','biblioitems'),
} elsif ( $module eq 'serial' ) {
push @{$field_selection},
add_fields( 'branches', 'biblio', 'biblioitems', 'borrowers', 'subscription', 'serial' );
} elsif ( $module eq 'suggestions' ) {
push @{$field_selection}, add_fields( 'suggestions', 'borrowers', 'biblio' );
} else {
push @{$field_selection}, add_fields( 'biblio', 'biblioitems' ),
add_fields('items'),
{value => 'items.content', text => 'items.content'},
{value => 'items.fine', text => 'items.fine'},
{ value => 'items.content', text => 'items.content' },
{ value => 'items.fine', text => 'items.fine' },
add_fields('borrowers');
if ($module eq 'circulation') {
push @{$field_selection}, add_fields('additional_contents', 'recalls');
if ( $module eq 'circulation' ) {
push @{$field_selection}, add_fields( 'additional_contents', 'recalls' );
}
@ -278,7 +272,7 @@ sub add_form {
push @{$field_selection}, add_fields('issues');
}
if ( $module eq 'circulation' and $code and $code =~ /^AR_/ ) {
if ( $module eq 'circulation' and $code and $code =~ /^AR_/ ) {
push @{$field_selection}, add_fields('article_requests');
}