Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33844: Fix is_denied_renewal

Browse source 
Going via result_set->has_column does cost actually nothing if
the object is already there.

Test plan:
Run again t/db_dependent/Koha/Item.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit a215087a6a)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2023-05-26 12:58:22 +00:00 committed by Pedro Amorim
parent b315b82793
commit c592b075f4
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/Item.pm
View file

@ -2044,6 +2044,8 @@ sub is_denied_renewal {
my $denyingrules = C4::Context->yaml_preference('ItemsDeniedRenewal');
return 0 unless $denyingrules;
foreach my $field (keys %$denyingrules) {
# Silently ignore bad column names; TODO we should validate elsewhere
next if !$self->_result->result_source->has_column($field);
my $val = $self->$field;
if( !defined $val) {
if ( any { !defined $_ } @{$denyingrules->{$field}} ){