Browse Source

Bug 27333: Throw the right exceptions

If parameters are missing, we need to throw
Koha::Exceptions::MissingParameter exceptions.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Club/Hold.t
=> FAIL: Tests fail because the method doesn't throw the right
exceptions
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
21.05.x
Tomás Cohen Arazi 2 years ago
committed by Jonathan Druart
parent
commit
c5f3fdcc15
  1. 11
      Koha/Club/Hold.pm

11
Koha/Club/Hold.pm

@ -26,6 +26,7 @@ use Koha::Database;
use Koha::Club::Template::Fields;
use base qw(Koha::Object);
use Koha::Exceptions;
use Koha::Exceptions::ClubHold;
use Koha::Club::Hold::PatronHold;
use Koha::Clubs;
@ -54,8 +55,14 @@ Class (static) method that returns a new Koha::Club::Hold instance
sub add {
my ( $params ) = @_;
Koha::Exceptions::ClubHold->throw()
unless $params->{club_id} && $params->{biblio_id};
# check for mandatory params
my @mandatory = ( 'biblio_id', 'club_id' );
for my $param (@mandatory) {
unless ( defined( $params->{$param} ) ) {
Koha::Exceptions::MissingParameter->throw(
error => "The $param parameter is mandatory" );
}
}
my $club = Koha::Clubs->find($params->{club_id});
my @enrollments = $club->club_enrollments->as_list;

Loading…
Cancel
Save