Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28769: Remove tabloop from cataloguing plugins

Browse source 
There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins.
But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array.

Actually this tabloop variable is never used from cataloguing plugins, we should remove it.

Test plan:
Read the code and confirm the above.
You can also test a couple of plugins and confirm that they are still
working.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2021-07-20 10:30:30 +02:00
parent 6ae81043b7
commit c66668b16c
58 changed files with 73 additions and 73 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/Items.pm
View file

@ -1757,7 +1757,7 @@ sub PrepareItemrecordDisplay {
name => $subfield->{value_builder},
item_style => 1,
});
my $pars = { dbh => $dbh, record => undef, tagslib =>$tagslib, id => $subfield_data{id}, tabloop => undef };
my $pars = { dbh => $dbh, record => undef, tagslib =>$tagslib, id => $subfield_data{id} };
$plugin->build( $pars );
if ( $itemrecord and my $field = $itemrecord->field($tag) ) {
$defaultvalue = $field->subfield($subfield->{subfield}) || q{};

4
Koha/FrameworkPlugin.pm
View file

@ -155,7 +155,7 @@ sub new {
Generate html and javascript by calling the builder sub of the plugin.
Params is a hashref supporting keys: id (=html id for the input field),
record (MARC record or undef), dbh (database handle), tagslib, tabloop.
record (MARC record or undef), dbh (database handle), tagslib.
Note that some of these parameters are not used in most (if not all)
plugins and may be obsoleted in the future (kept for now to provide
backward compatibility).
@ -276,7 +276,7 @@ sub _generate_js {
my @params = $self->{oldschool}//0 ?
( $params->{dbh}, $params->{record}, $params->{tagslib},
$params->{id}, $params->{tabloop} ):
$params->{id} ):
( $params );
my @rv = &$sub( @params );
return $self->_error( 'Builder sub failed: ' . $@ ) if $@;

14
authorities/authorities.pl
View file

@ -133,8 +133,8 @@ builds the <input ...> entry for a subfield.
=cut
sub create_input {
my ( $tag, $subfield, $value, $index_tag, $tabloop, $rec, $authorised_values_sth,$cgi ) = @_;
my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;
my $index_subfield = CreateKey(); # create a specifique key for each subfield
# determine maximum length; 9999 bytes per ISO 2709 except for leader and MARC21 008
@ -213,7 +213,7 @@ sub create_input {
name => $tagslib->{$tag}->{$subfield}->{'value_builder'},
});
my $pars= { dbh => $dbh, record => $rec, tagslib =>$tagslib,
id => $subfield_data{id}, tabloop => $tabloop };
id => $subfield_data{id} };
$plugin->build( $pars );
if( !$plugin->errstr ) {
$subfield_data{marc_value} = {
@ -410,7 +410,7 @@ sub build_tabs {
push(
@subfields_data,
&create_input(
$tag, $subfield, $value, $index_tag, $tabloop, $record,
$tag, $subfield, $value, $index_tag, $record,
$authorised_values_sth,$input
)
);
@ -426,7 +426,7 @@ sub build_tabs {
push(
@subfields_data,
&create_input(
$tag, $subfield, $value, $index_tag, $tabloop,
$tag, $subfield, $value, $index_tag,
$record, $authorised_values_sth,$input
)
);
@ -444,7 +444,7 @@ sub build_tabs {
push(
@subfields_data,
&create_input(
$tag, $subfield, '', $index_tag, $tabloop, $record,
$tag, $subfield, '', $index_tag, $record,
$authorised_values_sth,$input
)
);
@ -486,7 +486,7 @@ sub build_tabs {
push(
@subfields_data,
&create_input(
$tag, $subfield->{subfield}, '', $index_tag, $tabloop, $record,
$tag, $subfield->{subfield}, '', $index_tag, $record,
$authorised_values_sth,$input
)
);

12
cataloguing/addbiblio.pl
View file

@ -283,7 +283,7 @@ sub GetMandatoryFieldZ3950 {
=cut
sub create_input {
my ( $tag, $subfield, $value, $index_tag, $tabloop, $rec, $authorised_values_sth,$cgi ) = @_;
my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;
my $index_subfield = CreateKey(); # create a specifique key for each subfield
@ -394,7 +394,7 @@ sub create_input {
name => $tagslib->{$tag}->{$subfield}->{'value_builder'},
});
my $pars= { dbh => $dbh, record => $rec, tagslib => $tagslib,
id => $subfield_data{id}, tabloop => $tabloop };
id => $subfield_data{id} };
$plugin->build( $pars );
if( !$plugin->errstr ) {
$subfield_data{marc_value} = {
@ -567,7 +567,7 @@ sub build_tabs {
push(
@subfields_data,
&create_input(
$tag, $subfield, $value, $index_tag, $tabloop, $record,
$tag, $subfield, $value, $index_tag, $record,
$authorised_values_sth,$input
)
);
@ -582,7 +582,7 @@ sub build_tabs {
push(
@subfields_data,
&create_input(
$tag, $subfield, $value, $index_tag, $tabloop,
$tag, $subfield, $value, $index_tag,
$record, $authorised_values_sth,$input
)
);
@ -612,7 +612,7 @@ sub build_tabs {
push(
@subfields_data,
&create_input(
$tag, $subfield, '', $index_tag, $tabloop, $record,
$tag, $subfield, '', $index_tag, $record,
$authorised_values_sth,$input
)
);
@ -668,7 +668,7 @@ sub build_tabs {
push(
@subfields_data,
&create_input(
$tag, $subfield->{subfield}, '', $index_tag, $tabloop, $record,
$tag, $subfield->{subfield}, '', $index_tag, $record,
$authorised_values_sth,$input
)
);

6
cataloguing/additem.pl
View file

@ -59,7 +59,7 @@ use List::MoreUtils qw( any uniq );
our $dbh = C4::Context->dbh;
sub generate_subfield_form {
my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $subfields, $i, $restrictededition, $item) = @_;
my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $i, $restrictededition, $item) = @_;
my $frameworkcode = &GetFrameworkCode($biblionumber);
@ -241,7 +241,7 @@ sub generate_subfield_form {
item_style => 1,
});
my $pars= { dbh => $dbh, record => $temp, tagslib =>$tagslib,
id => $subfield_data{id}, tabloop => $subfields };
id => $subfield_data{id} };
$plugin->build( $pars );
if( !$plugin->errstr ) {
my $class= 'buttonDot'. ( $plugin->noclick? ' disabled': '' );
@ -889,7 +889,7 @@ foreach my $tag ( keys %{$tagslib} ) {
$value, $tagslib,
$subfield, $libraries,
$biblionumber, $temp,
\@subfields, $i,
$i,
$restrictededition, $current_item,
);
push @subfields, $subfield_data;

2
cataloguing/value_builder/unimarc_field_010.pl
View file

@ -26,7 +26,7 @@ use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $res="
<script>
function Blur$field_number() {

2
cataloguing/value_builder/unimarc_field_100.pl
View file

@ -30,7 +30,7 @@ use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number(i) {

2
cataloguing/value_builder/unimarc_field_100_authorities.pl
View file

@ -27,7 +27,7 @@ use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number(i) {

2
cataloguing/value_builder/unimarc_field_105.pl
View file

@ -30,7 +30,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $res="
<script>
function Clic$field_number() {

2
cataloguing/value_builder/unimarc_field_106.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= "106".(int(rand(100000))+1);
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_110.pl
View file

@ -30,7 +30,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $res="
<script>
function Clic$field_number() {

2
cataloguing/value_builder/unimarc_field_115a.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number(i) {

2
cataloguing/value_builder/unimarc_field_115b.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number() {

2
cataloguing/value_builder/unimarc_field_116.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $res = "
<script>
function Clic$field_number(i) {

2
cataloguing/value_builder/unimarc_field_117.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $res="
<script>
function Clic$field_number(i) {

2
cataloguing/value_builder/unimarc_field_120.pl
View file

@ -30,7 +30,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name=$field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_121a.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_121b.pl
View file

@ -27,7 +27,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_122.pl
View file

@ -27,7 +27,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_123a.pl
View file

@ -27,7 +27,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_123d.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_123e.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_123f.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_123g.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_123i.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_123j.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_124.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_124a.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_124b.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_124c.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_124d.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_124e.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_124f.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_124g.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_125.pl
View file

@ -34,7 +34,7 @@ plugin_parameters : other parameters added when the plugin is called by the dopo
=cut
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_125a.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_125b.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_126.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_126a.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_126b.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_127.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_128a.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_128b.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_128c.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_130.pl
View file

@ -30,7 +30,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_135a.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_140.pl
View file

@ -30,7 +30,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_141.pl
View file

@ -28,7 +28,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res="
<script>

2
cataloguing/value_builder/unimarc_field_210c.pl
View file

@ -31,7 +31,7 @@ use C4::AuthoritiesMarc qw( GetAuthority SearchAuthorities );
###TODO To rewrite in order to use SearchAuthorities
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
#---- build editors list.
#---- the editor list is built from the "EDITORS" thesaurus

2
cataloguing/value_builder/unimarc_field_210c_bis.pl
View file

@ -48,7 +48,7 @@ use C4::Auth qw( get_template_and_user );
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>

2
cataloguing/value_builder/unimarc_field_225a.pl
View file

@ -56,7 +56,7 @@ plugin_parameters : other parameters added when the plugin is called by the dopo
=cut
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>

2
cataloguing/value_builder/unimarc_field_225a_bis.pl
View file

@ -31,7 +31,7 @@ use C4::Context;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>

4
cataloguing/value_builder/unimarc_field_4XX.pl
View file

@ -36,12 +36,12 @@ use Koha::SearchEngine;
use Koha::SearchEngine::Search;
sub plugin_parameters {
my ( $dbh, $record, $tagslib, $i, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $i ) = @_;
return "";
}
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>

2
cataloguing/value_builder/unimarc_field_686a.pl
View file

@ -27,7 +27,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res = "
<script>

2
cataloguing/value_builder/unimarc_field_700-4.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name= $field_number;
my $res = "
<script>

2
cataloguing/value_builder/unimarc_leader.pl
View file

@ -29,7 +29,7 @@ use C4::Search;
use C4::Output qw( output_html_with_http_headers );
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my ( $dbh, $record, $tagslib, $field_number ) = @_;
my $function_name = $field_number;
my $res = "
<script>

2
t/db_dependent/FrameworkPlugin.t
View file

@ -222,7 +222,7 @@ sub old01 {
# includes a typical empty Clic function and plugin subroutine
return mytempfile( <<'HERE'
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my ($dbh,$record,$tagslib,$field_number) = @_;
my $function_name = $field_number;
my $res = "
<script type=\"text/javascript\">

2
tools/batchMod.pl
View file

@ -532,7 +532,7 @@ foreach my $tag (sort keys %{$tagslib}) {
});
my $temp;
my $pars= { dbh => $dbh, record => $temp, tagslib => $tagslib,
id => $subfield_data{id}, tabloop => \@loop_data };
id => $subfield_data{id} };
$plugin->build( $pars );
if( !$plugin->errstr ) {
$subfield_data{marc_value} = {