Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31378: Tests shouldn't remove all patrons

Browse source 
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Tomás Cohen Arazi 2022-11-22 18:23:07 -03:00
parent 0945407904
commit c6e5467e5f
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 21 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
t/db_dependent/Koha/REST/Plugin/Auth/IdP.t
View file

@ -86,19 +86,33 @@ subtest 'auth.register helper' => sub {
$schema->storage->txn_begin;
# Remove existing patrons
Koha::Patrons->delete;
my $provider = $builder->build_object( { class => 'Koha::Auth::Identity::Providers', value => { matchpoint => 'email' } } );
# generate a random patron
my $patron_to_delete = $builder->build_object({ class => 'Koha::Patrons' });
my $userid = $patron_to_delete->userid;
# delete patron
$patron_to_delete->delete;
my $provider = $builder->build_object( { class => 'Koha::Auth::Identity::Providers', value => { matchpoint => 'email' } } );
my $domain_with_register = $builder->build_object(
{ class => 'Koha::Auth::Identity::Provider::Domains', value => { identity_provider_id => $provider->id, domain => 'domain1.com', auto_register => 1 } } );
{ class => 'Koha::Auth::Identity::Provider::Domains',
value => { identity_provider_id => $provider->id, domain => 'domain1.com', auto_register => 1 }
}
);
my $domain_without_register = $builder->build_object(
{ class => 'Koha::Auth::Identity::Provider::Domains', value => { identity_provider_id => $provider->id, domain => 'domain2.com', auto_register => 0 } } );
{ class => 'Koha::Auth::Identity::Provider::Domains',
value => { identity_provider_id => $provider->id, domain => 'domain2.com', auto_register => 0 }
}
);
my $library = $builder->build_object( { class => 'Koha::Libraries' } );
my $category = $builder->build_object( { class => 'Koha::Patron::Categories' } );
my $user_data = {
firstname => 'test',
surname => 'test',
userid => 'id1',
userid => $userid,
branchcode => $library->branchcode,
categorycode => $category->categorycode
};
@ -110,6 +124,7 @@ subtest 'auth.register helper' => sub {
$t->post_ok( '/register_user' => json => { data => $user_data, domain_id => $domain_without_register->identity_provider_domain_id, interface => 'opac' } )->status_is(401)
->json_has( '/message', 'unauthorized' );
$schema->storage->txn_rollback;
};
@ -118,8 +133,6 @@ subtest 'auth.session helper' => sub {
$schema->storage->txn_begin;
# Remove existing patrons
Koha::Patrons->delete;
my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
my $t = Test::Mojo->new;