Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34478: Rename action with op - mod_debarment

Browse source 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2024-01-31 10:51:49 +01:00
parent 48c2364f67
commit c790129c7d
Signed by: jonathan.druart
GPG key ID: A085E712BEF0E0F0
2 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc
View file

@ -41,9 +41,13 @@
<td>[% restriction.created | $KohaDates %]</td>
[% IF CAN_user_borrowers_edit_borrowers && CAN_user_circulate_manage_restrictions %]
<td>
<a class="remove_restriction btn btn-default btn-xs" href="/cgi-bin/koha/members/mod_debarment.pl?borrowernumber=[% patron.borrowernumber | html %]&amp;borrower_debarment_id=[% restriction.borrower_debarment_id | html %]&amp;action=del">
<i class="fa fa-trash-can"></i> Remove
</a>
<form method="post" action="/cgi-bin/koha/members/mod_debarment.pl">
[% INCLUDE 'csrf-token.inc' %]
<input type="hidden" name="op" value="cud-del" />
<input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | uri %]" />
<input type="hidden" name="borrower_debarment_id" value="[% restriction.borrower_debarment_id | uri %]" />
<button type="submit" class="remove_restriction btn btn-default btn-xs"><i class="fa fa-trash-can"></i> Remove</button>
</form>
</td>
[% END %]
</tr>
@ -56,7 +60,7 @@
<form method="post" action="/cgi-bin/koha/members/mod_debarment.pl" class="clearfix">
[% INCLUDE 'csrf-token.inc' %]
<input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" />
<input type="hidden" name="action" value="add" />
<input type="hidden" name="op" value="cud-add" />
<fieldset class="rows" id="manual_restriction_form">
<legend>Add manual restriction</legend>
<ol>

8
members/mod_debarment.pl
View file

@ -30,7 +30,7 @@ my $cgi = CGI->new;
my ( $loggedinuserid, $cookie, $sessionID ) = checkauth( $cgi, 0, { borrowers => 'edit_borrowers' }, 'intranet' );
my $borrowernumber = $cgi->param('borrowernumber');
my $action = $cgi->param('action');
my $op = $cgi->param('op');
my $logged_in_user = Koha::Patrons->find( { userid => $loggedinuserid } );
my $patron = Koha::Patrons->find($borrowernumber);
@ -38,11 +38,11 @@ my $patron = Koha::Patrons->find($borrowernumber);
# Ideally we should display a warning on the interface if the patron is not allowed
# to modify a debarment
# But a librarian is not supposed to hack the system
$action = '' unless $logged_in_user->can_see_patron_infos( $patron );
$op = '' unless $logged_in_user->can_see_patron_infos( $patron );
if ( $action eq 'cud-del' ) {
if ( $op eq 'cud-del' ) {
DelDebarment( scalar $cgi->param('borrower_debarment_id') );
} elsif ( $action eq 'cud-add' ) {
} elsif ( $op eq 'cud-add' ) {
my $expiration = $cgi->param('expiration');
my $type = $cgi->param('debarred_type') // 'MANUAL';
if ($expiration) {