Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback

Browse source 
This resolves:
DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1)
Removing unneeded subtest txn's. We should probably add them everywhere or
just at global level.

Test plan:
With all three patches applied, run Circulation.t a few times.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2019-06-21 09:15:18 +00:00 committed by Martin Renvoize
parent 95a303c8f3
commit c7a707d60b
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
t/db_dependent/Circulation.t
View file

@ -3042,7 +3042,6 @@ subtest 'AddRenewal and AddIssuingCharge tests' => sub {
plan tests => 13;
$schema->storage->txn_begin;
t::lib::Mocks::mock_preference('item-level_itypes', 1);
@ -3129,14 +3128,12 @@ subtest 'AddRenewal and AddIssuingCharge tests' => sub {
is( $line->branchcode, $library->id, 'AddRenewal correctly sets branchcode' );
is( $line->description, "Renewal of Rental Item $title $barcode", 'AddRenewal set a hardcoded description for the accountline' );
$schema->storage->txn_rollback;
};
subtest 'ProcessOfflinePayment() tests' => sub {
plan tests => 4;
$schema->storage->txn_begin;
my $amount = 123;
@ -3153,7 +3150,6 @@ subtest 'ProcessOfflinePayment() tests' => sub {
is( $line->amount+0, $amount * -1, 'amount picked from params' );
is( $line->branchcode, $library->id, 'branchcode set correctly' );
$schema->storage->txn_rollback;
};
subtest 'Incremented fee tests' => sub {