Browse Source

Bug 15258: Prevent unused declared variables

Add a perlcritic rule to 00-perlcritic.t to prevent unused declared
variable.

TO TEST:

- Apply the 1st patch (unit test)
- Run the UT:
  prove -v t/00-testcritic.t
- Note that several Perl script fail
- Apply the 2nd patch
- Run the UT, and confirm it passes.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
All tests pass successful.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
new_12478_elasticsearch
Frédéric Demians 7 years ago
committed by Jesse Weaver
parent
commit
c7ec79b839
  1. 31
      t/00-testcritic.t
  2. 5
      t/perlcriticrc

31
t/00-testcritic.t

@ -1,6 +1,4 @@
#!/usr/bin/env perl
use strict;
use warnings;
# This script can be used to run perlcritic on perl files in koha
# It calls its own custom perlcriticrc
@ -8,16 +6,33 @@ use warnings;
# and the environment variable TEST_QA to be set
# At present only the directories in @dirs will pass the tests in 'Gentle' mode
use Modern::Perl;
use File::Spec;
use Test::More;
use English qw(-no_match_vars);
my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing circ course_reserves debian errors
labels members misc offline_circ opac patroncards patron_lists reports reserve reviews rotating_collections
serials sms suggestion t tags test tools virtualshelves Koha);
my @dirs = qw( acqui admin authorities basket catalogue cataloguing circ debian errors labels
members offline_circ reserve reviews rotating_collections serials sms virtualshelves Koha C4/SIP);
my @dirs = qw(
acqui
admin
authorities
basket
catalogue
cataloguing
circ
debian
errors
labels
members
offline_circ
reserve
reviews
rotating_collections
serials
sms
virtualshelves
Koha
C4/SIP
);
if ( not $ENV{TEST_QA} ) {
my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run';

5
t/perlcriticrc

@ -1,6 +1,7 @@
severity = 5
include = ProhibitUnusedVariables
exclude = Miscellanea::RequireRcsKeywords
[Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval]
allow_includes =1
@ -8,4 +9,4 @@ allow_includes =1
equivalent_modules = Modern::Perl
[TestingAndDebugging::RequireUseWarnings]
equivalent_modules = Modern::Perl
equivalent_modules = Modern::Perl

Loading…
Cancel
Save