Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 22001: Errors are no longer logged by default (!)

Browse source 
This is one of the biggest part we will have to deal with when we will
switch to DBIC handler for UI as well.
The DBI errors will not be logged if we do not deal with them correctly.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2020-03-31 17:56:41 +02:00 committed by Martin Renvoize
parent ddbe2753ba
commit c800ef7e59
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 3 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
t/db_dependent/Koha/Objects.t
View file

@ -579,7 +579,7 @@ subtest 'Return same values as DBIx::Class' => sub {
subtest 'Koha::Objects->delete' => sub {
plan tests => 9;
plan tests => 7;
my ( $r_us, $e_us, $r_them, $e_them );
@ -687,11 +687,7 @@ subtest 'Return same values as DBIx::Class' => sub {
}
);
warning_like {
try { $r_us = $patrons->delete; } catch { $e_us = $_ };
}
qr{DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails},
"Foreign key constraint DBI error should be logged";
try { $r_us = $patrons->delete; } catch { $e_us = $_ };
my $not_deleted_us = $patron_1->in_storage + $patron_2->in_storage + $patron_3->in_storage;
$patron_1 = $builder->build_object({ class => 'Koha::Patrons' });
@ -717,11 +713,7 @@ subtest 'Return same values as DBIx::Class' => sub {
}
);
warning_like {
try { $r_them = $patrons->delete; } catch { $e_them = $_ };
}
qr{DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails},
"Foreign key constraint DBI error should be logged";
try { $r_them = $patrons->delete; } catch { $e_them = $_ };
my $not_deleted_them = $patron_1->in_storage + $patron_2->in_storage + $patron_3->in_storage;
ok(