Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27760: (QA follow-up) Improve POD

Browse source 
This patch improves the POD for the added helper, and also adds
references to the JSON::Validator issue that explains the current
implementation. A FIXME is added for when we upgrade our used
JSON::Validator version.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomás Cohen Arazi 2021-03-11 08:03:13 -03:00 committed by Jonathan Druart
parent 25b08f9989
commit c80d4655cc
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Koha/REST/Plugin/Query.pm
View file

@ -268,7 +268,19 @@ Merges parameters from $q_params into $filtered_params.
=head3 stash_overrides
# Stash the overrides
$c->stash_overrides();
#Use it
my $overrides = $c->stash('koha.overrides');
if ( $overrides->{pickup_location} ) { ... }
This helper method parses 'x-koha-override' headers and stashes the passed overriders
in the for of a I<hashref> for easy use in controller methods.
FIXME: With the currently used JSON::Validator version we use, it is not possible to
use the validated and coerced data (it doesn't validate array-type headers) so this
implementation relies on manual parsing. Look at the JSON::Validator changelog for
reference: https://metacpan.org/changes/distribution/JSON-Validator#L14
=cut