Koha-community
/
Koha
13
5
Fork 0
Code Issues Releases Wiki Activity
Browse Source

Bug 32632: Add 'page-section' to some tools pages 

This patch adds a "page-section" container div around the main section
of some tools pages which lack it.

This patch contains indentation changes, so please ignore whitespace
when looking at the diff.

Apply the patch and view the following pages to confirm that the main
content is contained in a white box:

 - From the cataloging home page: Item modifications by age. If
   necessary, add at least one rule to see the table listing all rules.
 - Go to Tools -> Batch extend due dates, and submit values which will
   return one or more results, keeping the "Preview results" checkbox
   checked. Confirm that the page previewing the results looks
   correct.
 - Go to Tools -> Quote editor. If necessary, add at least one quote in
   order to see the table of quotes.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
23.05.x
Owen Leonard 1 year ago
committed by Martin Renvoize
parent
d3b4edf009
commit
c8d4fa56d3
Signed by: martin.renvoize GPG Key ID: 422B469130441A0F
3 changed files with 40 additions and 33 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 3
      koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
  2. 46
      koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt
  3. 24
      koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt

3
koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
View File

@ -216,6 +216,8 @@
[% ELSIF rules %]
<div>
<h4>List of rules</h4>
<div class="page-section">
<table id="rulest">
<thead>
<tr>
@ -265,6 +267,7 @@
[% END %]
</tbody>
</table>
</div> <!-- /.page-section -->
</div>
[% ELSE %]
<div class="dialog message">

46
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt
View File

@ -182,30 +182,32 @@
Due dates have been modified!
</div>
<table id="checkouts_result">
<thead>
<tr>
<th>Due date</th>
<th>Title</th>
<th>Item type</th>
<th>Home library</th>
<th>Checked out on</th>
<th>Checked out from</th>
</tr>
</thead>
<tbody>
[% FOR checkout IN checkouts %]
<div class="page-section">
<table id="checkouts_result">
<thead>
<tr>
<td>[% checkout.date_due | $KohaDates as_due_date => 1 %]</td>
<td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% checkout.item.biblio.biblionumber | uri %]">[% checkout.item.biblio.title | html %]</a></td>
<td>[% ItemTypes.GetDescription( checkout.item.effective_itemtype ) | html %]</td>
<td>[% checkout.item.home_branch.branchname | html %]</td>
<td>[% checkout.issuedate | $KohaDates %]</td>
<td>[% Branches.GetName( checkout.branchcode ) | html %]</td>
<th>Due date</th>
<th>Title</th>
<th>Item type</th>
<th>Home library</th>
<th>Checked out on</th>
<th>Checked out from</th>
</tr>
[% END %]
</tbody>
</table> <!-- /#checkouts_result -->
</thead>
<tbody>
[% FOR checkout IN checkouts %]
<tr>
<td>[% checkout.date_due | $KohaDates as_due_date => 1 %]</td>
<td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% checkout.item.biblio.biblionumber | uri %]">[% checkout.item.biblio.title | html %]</a></td>
<td>[% ItemTypes.GetDescription( checkout.item.effective_itemtype ) | html %]</td>
<td>[% checkout.item.home_branch.branchname | html %]</td>
<td>[% checkout.issuedate | $KohaDates %]</td>
<td>[% Branches.GetName( checkout.branchcode ) | html %]</td>
</tr>
[% END %]
</tbody>
</table> <!-- /#checkouts_result -->
</div> <!-- /.page-section -->
[% END %]
</main>
</div> <!-- /.col-sm-10.col-sm-push-2 -->

24
koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt
View File

@ -106,17 +106,19 @@
[% IF op == 'list' %]
<h1>Quotes</h1>
[% IF quotes_count > 0 %]
<table id="quotes">
<thead>
<tr>
<th>ID</th>
<th>Source</th>
<th>Text</th>
<th>Last display</th>
<th data-class-name="actions" class="noExport">Actions</th>
</tr>
</thead>
</table>
<div class="page-section">
<table id="quotes">
<thead>
<tr>
<th>ID</th>
<th>Source</th>
<th>Text</th>
<th>Last display</th>
<th data-class-name="actions" class="noExport">Actions</th>
</tr>
</thead>
</table>
</div> <!-- /.page-section -->
[% ELSE %]
<div class="dialog message">There are no quotes defined. <a href="/cgi-bin/koha/tools/quotes.pl?op=add_form">Start defining quotes</a>.</div>
[% END %]

Write Preview
Loading…
Cancel
Save