Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 20948: Only display item-level hold info if first hold

Browse source 
On the item list of the catalogue detail page we display next item-level
hold info even if it is not the next hold. That leads to confusion as it
will not necessarily be the accurate info.

This patch makes the following changes:
- Display the item-level hold only if it is the next hold (priority ==
1)
- Display "There is an item level hold on this item (priority=X)"
if there is at least 1 item-level hold placed on this item

Test plan:
- Place several next available holds on a single item record
- Place an item level hold on the item
- Go the the biblio detail page
=> Without this patch, the item will show the item level hold
=> With the patch you see "There is an item level hold on this item"
- Check the item in, confirm the hold
=> No changes, the item will show the waiting hold info
- Cancel all the holds except the item-level one
=> No changes, the item will how the item-level one

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2019-11-18 10:30:04 +01:00 committed by Martin Renvoize
parent 93b2905bdf
commit ca501374af
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
View file

@ -359,10 +359,12 @@
[% IF hold %]
[% IF hold.waitingdate %]
Waiting at [% Branches.GetName( hold.branchcode ) | html %] since [% hold.waitingdate | $KohaDates %].
[% ELSE %]
[% ELSIF hold.priority == 1 %]
Item-level hold (placed [% hold.reservedate | $KohaDates %]) for delivery at [% Branches.GetName( hold.branchcode ) | html %].
[% ELSE %]
There is an item level hold on this item (priority = [% hold.priority %]).
[% END %]
[% IF ( canreservefromotherbranches ) %]
[% IF canreservefromotherbranches AND ( hold.waitingdate OR hold.priority == 1 ) %]
Hold for:
[% INCLUDE 'patron-title.inc' patron=hold.borrower hide_patron_infos_if_needed=1 %]
[% END %]