Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34478: Corrections to add and delete of OAI sets

Browse source 
This patch makes two changes: The first changes the name of the op value
matched in the script when editing a set. The "mod" step is a GET
operation to load the edit form.

The second change is a workaround for the fact that a submit
button looks bad in a Bootstrap dropdown. The patch creates a hidden
form for deletion operations. Clicking a "delete" link in a dropdown
fills the hidden form with the OAI set id to be deleted and submits it.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Owen Leonard 2024-02-16 14:18:06 +00:00 committed by Jonathan Druart
parent ecbb2f9a52
commit cb1f73b1bc
Signed by: jonathan.druart
GPG key ID: A085E712BEF0E0F0
2 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
admin/oai_sets.pl
View file

@ -55,7 +55,7 @@ if($op && $op eq "new") {
name => $name,
descriptions => \@descriptions
});
} elsif($op && $op eq "cud-mod") {
} elsif($op && $op eq "mod") {
my $id = $input->param('id');
my $set = GetOAISet($id);
$template->param(

20
koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt
View file

@ -139,7 +139,7 @@
Actions <b class="caret"></b></a>
<ul class="dropdown-menu pull-right" role="menu" aria-labelledby="oaisetsactions[% set.id | html %]">
<li><a href="/cgi-bin/koha/admin/oai_sets.pl?op=mod&amp;id=[% set.id | uri %]"><i class="fa-fw fa-solid fa-pencil" aria-hidden="true"></i> Edit</a></li>
<li><a class="delete_oai_set" href="/cgi-bin/koha/admin/oai_sets.pl?op=del&amp;id=[% set.id | html %]"><i class="fa fa-fw fa-trash-can"></i> Delete</a></li>
<li><a class="delete_oai_set" data-oai-set-id="[% set.id | html %]" href="#"><i class="fa fa-fw fa-trash-can"></i> Delete</a></li>
<li><a href="/cgi-bin/koha/admin/oai_set_mappings.pl?id=[% set.id | uri %]"><i class="fa fa-fw fa-info"></i> Define mappings</a></li>
</ul>
</div>
@ -148,6 +148,11 @@
[% END %]
</tbody>
</table>
<form action="/cgi-bin/koha/admin/oai_sets.pl" id="oai_sets_delete" method="post">
[% INCLUDE 'csrf-token.inc' %]
<input type="hidden" name="op" value="cud-del" />
<input type="hidden" id="oai_sets_id" name="id" value="" />
</form>
</div> <!-- /.page-section -->
[% ELSE %]
<div class="dialog message"><p>There are no sets defined.</p></div>
@ -181,13 +186,14 @@
$(li).remove();
}
function confirmDelete() {
return confirm(_("Are you sure you want to delete this OAI set?"));
}
$(document).ready(function() {
$(".delete_oai_set").on("click",function(){
return confirmDelete();
$(".delete_oai_set").on("click",function(e){
e.preventDefault();
if( confirm(_("Are you sure you want to delete this OAI set?")) ){
let oai_set_id = $(this).data("oai-set-id");
$("#oai_sets_id").val( oai_set_id );
$("#oai_sets_delete").submit();
}
});
$("body").on("click", ".remove_description", function(e){