Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 26367: Unit test

Browse source 
This warn only appears when:
  The borrower and item branches match
  AND
  The hold fulfillment policy is any or the pickupbranch matches the items branch specified by hold_fulfillment_policy
  AND
  The request has an itemtype set

To trigger we simply add some itemtype to existing hold requests in the test

To test:
1 - prove -v t/db_dependent/HoldsQueue.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2020-09-03 12:06:51 +00:00 committed by Jonathan Druart
parent d9063ba246
commit cd83fbe58d
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
t/db_dependent/HoldsQueue.t
View file

@ -1413,7 +1413,8 @@ subtest 'Excludes from local holds priority' => sub {
branchcode => $other_patron->branchcode,
borrowernumber => $other_patron->borrowernumber,
biblionumber => $item1->biblionumber,
priority => 1
priority => 1,
itemtype => $item1->effective_itemtype
}
);
@ -1422,7 +1423,8 @@ subtest 'Excludes from local holds priority' => sub {
branchcode => $local_patron_excluded->branchcode,
borrowernumber => $local_patron_excluded->borrowernumber,
biblionumber => $item1->biblionumber,
priority => 2
priority => 2,
itemtype => $item1->effective_itemtype
}
);
@ -1431,7 +1433,8 @@ subtest 'Excludes from local holds priority' => sub {
branchcode => $local_patron_not_excluded->branchcode,
borrowernumber => $local_patron_not_excluded->borrowernumber,
biblionumber => $item1->biblionumber,
priority => 3
priority => 3,
itemtype => $item1->effective_itemtype
}
);